linux-kernel - [PATCH] virtio-fs: fix incorrect check for fsvq->kobj

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251027104658.1668537-1-alok.a.tiwari@oracle.com>
Date: Mon, 27 Oct 2025 03:46:47 -0700
From: Alok Tiwari <alok.a.tiwari@...cle.com>
To: mgurtovoy@...dia.com, izach@...dia.com, smalin@...dia.com,
        vgoyal@...hat.com, stefanha@...hat.com, miklos@...redi.hu,
        eperezma@...hat.com, mst@...hat.com, jasowang@...hat.com,
        virtualization@...ts.linux.dev, linux-fsdevel@...r.kernel.org,
        alok.a.tiwari@...cle.com
Cc: alok.a.tiwarilinux@...il.com, linux-kernel@...r.kernel.org
Subject: [PATCH] virtio-fs: fix incorrect check for fsvq->kobj

In virtio_fs_add_queues_sysfs(), the code incorrectly checks fs->mqs_kobj
after calling kobject_create_and_add(). Change the check to fsvq->kobj
(fs->mqs_kobj -> fsvq->kobj) to ensure the per-queue kobject is
successfully created.

Fixes: 87cbdc396a31 ("virtio_fs: add sysfs entries for queue information")
Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>
---
 fs/fuse/virtio_fs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c
index 6bc7c97b017d..b2f6486fe1d5 100644
--- a/fs/fuse/virtio_fs.c
+++ b/fs/fuse/virtio_fs.c
@@ -373,7 +373,7 @@ static int virtio_fs_add_queues_sysfs(struct virtio_fs *fs)
 
 		sprintf(buff, "%d", i);
 		fsvq->kobj = kobject_create_and_add(buff, fs->mqs_kobj);
-		if (!fs->mqs_kobj) {
+		if (!fsvq->kobj) {
 			ret = -ENOMEM;
 			goto out_del;
 		}
-- 
2.50.1