linux-kernel - Re: [PATCH v1] arm64: dts: qcom: ipq5424: add gpio regulator for cpu power supply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4265f8a8-b26d-45b3-9fdc-5438ea9e931b@quicinc.com>
Date: Mon, 27 Oct 2025 17:23:41 +0530
From: Manikanta Mylavarapu <quic_mmanikan@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>, <andersson@...nel.org>,
        <konradybcio@...nel.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
        <conor+dt@...nel.org>, <linux-arm-msm@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC: <quic_srichara@...cinc.com>, <quic_varada@...cinc.com>,
        <kathiravan.thirumoorthy@....qualcomm.com>
Subject: Re: [PATCH v1] arm64: dts: qcom: ipq5424: add gpio regulator for cpu
 power supply



On 10/23/2025 8:03 PM, Konrad Dybcio wrote:
> On 10/23/25 6:02 AM, Manikanta Mylavarapu wrote:
>> Add a GPIO-controlled regulator node for the CPU rail on the
>> IPQ5424 RDP466 platform. This regulator supports two voltage
>> levels 850mV and 1000mV.
>>
>> Update CPU nodes to reference the regulator via the `cpu-supply`
>> property, and add the required pinctrl configuration for GPIO17.
>>
>> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@...cinc.com>
>> ---
>>  arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts | 24 +++++++++++++++++++++
>>  arch/arm64/boot/dts/qcom/ipq5424.dtsi       |  4 ++++
>>  2 files changed, 28 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
>> index 738618551203..6d14eb2fe821 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
>> +++ b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
>> @@ -46,6 +46,23 @@ led-0 {
>>  		};
>>  	};
>>  
>> +	vreg_apc: regulator-vreg-apc {
>> +		compatible = "regulator-gpio";
>> +		regulator-name = "vreg_apc";
>> +		regulator-min-microvolt = <850000>;
>> +		regulator-max-microvolt = <1000000>;
>> +		regulator-boot-on;
>> +		regulator-always-on;
>> +		regulator-ramp-delay = <250>;
>> +
>> +		gpios = <&tlmm 17 GPIO_ACTIVE_HIGH>;
>> +		gpios-states = <1>;
>> +		states = <850000 0>, <1000000 1>;
> 
> Atop Dmitry's comment, please make the states entries 1 a line

Hi Konrad,

Thank you for reviewing the patch.
I will incorporate the suggested change in the next version.

Thanks & Regards,
Manikanta.