[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <35a3434c-9408-472d-8575-6efa2ea28e12@quicinc.com>
Date: Mon, 27 Oct 2025 17:23:51 +0530
From: Manikanta Mylavarapu <quic_mmanikan@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
CC: <andersson@...nel.org>, <konradybcio@...nel.org>, <robh@...nel.org>,
<krzk+dt@...nel.org>, <conor+dt@...nel.org>,
<linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <quic_srichara@...cinc.com>,
<quic_varada@...cinc.com>, <kathiravan.thirumoorthy@....qualcomm.com>
Subject: Re: [PATCH v1] arm64: dts: qcom: ipq5424: add gpio regulator for cpu
power supply
On 10/23/2025 7:42 PM, Dmitry Baryshkov wrote:
> On Thu, Oct 23, 2025 at 09:32:24AM +0530, Manikanta Mylavarapu wrote:
>> Add a GPIO-controlled regulator node for the CPU rail on the
>> IPQ5424 RDP466 platform. This regulator supports two voltage
>> levels 850mV and 1000mV.
>>
>> Update CPU nodes to reference the regulator via the `cpu-supply`
>> property, and add the required pinctrl configuration for GPIO17.
>>
>> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@...cinc.com>
>> ---
>> arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts | 24 +++++++++++++++++++++
>> arch/arm64/boot/dts/qcom/ipq5424.dtsi | 4 ++++
>> 2 files changed, 28 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
>> index 738618551203..6d14eb2fe821 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
>> +++ b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
>> @@ -46,6 +46,23 @@ led-0 {
>> };
>> };
>>
>> + vreg_apc: regulator-vreg-apc {
>> + compatible = "regulator-gpio";
>> + regulator-name = "vreg_apc";
>> + regulator-min-microvolt = <850000>;
>> + regulator-max-microvolt = <1000000>;
>> + regulator-boot-on;
>> + regulator-always-on;
>> + regulator-ramp-delay = <250>;
>> +
>> + gpios = <&tlmm 17 GPIO_ACTIVE_HIGH>;
>> + gpios-states = <1>;
>> + states = <850000 0>, <1000000 1>;
>> +
>> + pinctrl-0 = <®ulator_gpio_default>;
>> + pinctrl-names = "default";
>
> 'vreg' > 'usb'
>
Hi Dmitry,
Thank you for reviewing the patch.
I will incorporate the suggested change in the next version.
Thanks & Regards,
Manikanta.
Powered by blists - more mailing lists