linux-kernel - Re: [net-next, v3] net: mana: Support HW link state events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76598660-8b8e-4fe6-974b-5f3eb431a1ec@redhat.com>
Date: Tue, 28 Oct 2025 15:31:28 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Haiyang Zhang <haiyangz@...ux.microsoft.com>,
 linux-hyperv@...r.kernel.org, netdev@...r.kernel.org
Cc: haiyangz@...rosoft.com, paulros@...rosoft.com, decui@...rosoft.com,
 kys@...rosoft.com, wei.liu@...nel.org, edumazet@...gle.com,
 davem@...emloft.net, kuba@...nel.org, longli@...rosoft.com,
 ssengar@...ux.microsoft.com, ernis@...ux.microsoft.com,
 dipayanroy@...ux.microsoft.com, kotaranov@...rosoft.com, horms@...nel.org,
 shradhagupta@...ux.microsoft.com, leon@...nel.org, mlevitsk@...hat.com,
 yury.norov@...il.com, shirazsaleem@...rosoft.com, andrew+netdev@...n.ch,
 linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [net-next, v3] net: mana: Support HW link state events

On 10/24/25 3:41 AM, Haiyang Zhang wrote:
> @@ -3243,6 +3278,8 @@ static int mana_probe_port(struct mana_context *ac, int port_idx,
>  		goto free_indir;
>  	}
>  
> +	netif_carrier_on(ndev);

Why is  the above needed? I thought mana_link_state_handle() should kick
and set the carrier on as needed???

/P