linux-kernel - RE: [EXTERNAL] Re: [net-next, v3] net: mana: Support HW link state events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <BY1PR21MB3870D5B860FB1F26932EB73ACAFDA@BY1PR21MB3870.namprd21.prod.outlook.com>
Date: Tue, 28 Oct 2025 19:36:02 +0000
From: Haiyang Zhang <haiyangz@...rosoft.com>
To: Paolo Abeni <pabeni@...hat.com>, Haiyang Zhang
	<haiyangz@...ux.microsoft.com>, "linux-hyperv@...r.kernel.org"
	<linux-hyperv@...r.kernel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, Paul Rosswurm <paulros@...rosoft.com>
CC: Dexuan Cui <DECUI@...rosoft.com>, KY Srinivasan <kys@...rosoft.com>,
	"wei.liu@...nel.org" <wei.liu@...nel.org>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "davem@...emloft.net" <davem@...emloft.net>,
	"kuba@...nel.org" <kuba@...nel.org>, Long Li <longli@...rosoft.com>,
	"ssengar@...ux.microsoft.com" <ssengar@...ux.microsoft.com>,
	"ernis@...ux.microsoft.com" <ernis@...ux.microsoft.com>,
	"dipayanroy@...ux.microsoft.com" <dipayanroy@...ux.microsoft.com>, Konstantin
 Taranov <kotaranov@...rosoft.com>, "horms@...nel.org" <horms@...nel.org>,
	"shradhagupta@...ux.microsoft.com" <shradhagupta@...ux.microsoft.com>,
	"leon@...nel.org" <leon@...nel.org>, "mlevitsk@...hat.com"
	<mlevitsk@...hat.com>, "yury.norov@...il.com" <yury.norov@...il.com>, Shiraz
 Saleem <shirazsaleem@...rosoft.com>, "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>, "linux-rdma@...r.kernel.org"
	<linux-rdma@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [EXTERNAL] Re: [net-next, v3] net: mana: Support HW link state
 events



> -----Original Message-----
> From: Paolo Abeni <pabeni@...hat.com>
> Sent: Tuesday, October 28, 2025 10:31 AM
> To: Haiyang Zhang <haiyangz@...ux.microsoft.com>; linux-
> hyperv@...r.kernel.org; netdev@...r.kernel.org
> Cc: Haiyang Zhang <haiyangz@...rosoft.com>; Paul Rosswurm
> <paulros@...rosoft.com>; Dexuan Cui <DECUI@...rosoft.com>; KY Srinivasan
> <kys@...rosoft.com>; wei.liu@...nel.org; edumazet@...gle.com;
> davem@...emloft.net; kuba@...nel.org; Long Li <longli@...rosoft.com>;
> ssengar@...ux.microsoft.com; ernis@...ux.microsoft.com;
> dipayanroy@...ux.microsoft.com; Konstantin Taranov
> <kotaranov@...rosoft.com>; horms@...nel.org;
> shradhagupta@...ux.microsoft.com; leon@...nel.org; mlevitsk@...hat.com;
> yury.norov@...il.com; Shiraz Saleem <shirazsaleem@...rosoft.com>;
> andrew+netdev@...n.ch; linux-rdma@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: [EXTERNAL] Re: [net-next, v3] net: mana: Support HW link state
> events
> 
> On 10/24/25 3:41 AM, Haiyang Zhang wrote:
> > @@ -3243,6 +3278,8 @@ static int mana_probe_port(struct mana_context
> *ac, int port_idx,
> >  		goto free_indir;
> >  	}
> >
> > +	netif_carrier_on(ndev);
> 
> Why is  the above needed? I thought mana_link_state_handle() should kick
> and set the carrier on as needed???

Thanks for the question -- our MANA NIC only sends out the link state down/up 
messages when need to let the VM rerun DHCP client and change IP address...

So, I need to add netif_carrier_on(ndev) in the probe(), otherwise the 
/sys/class/net/ethX/operstate will remain "unknown" until it receives the 
Link down/up messages which do NOT always happen.

Cc: @Paul Rosswurm

- Haiyang