linux-kernel - Re: [PATCH v5 04/35] x86/cpuid: Rename cpuid_leaf()/cpuid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251028175039.GCaQECb5EqT1_pwqX3@fat_crate.local>
Date: Tue, 28 Oct 2025 18:50:39 +0100
From: Borislav Petkov <bp@...en8.de>
To: "Ahmed S. Darwish" <darwi@...utronix.de>
Cc: Ingo Molnar <mingo@...hat.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Cooper <andrew.cooper3@...rix.com>,
	Sean Christopherson <seanjc@...gle.com>,
	David Woodhouse <dwmw2@...radead.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Sohil Mehta <sohil.mehta@...el.com>,
	John Ogness <john.ogness@...utronix.de>, x86@...nel.org,
	x86-cpuid@...ts.linux.dev, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 04/35] x86/cpuid: Rename cpuid_leaf()/cpuid_subleaf()
 APIs

On Fri, Sep 05, 2025 at 02:14:44PM +0200, Ahmed S. Darwish wrote:
> diff --git a/arch/x86/include/asm/cpuid/api.h b/arch/x86/include/asm/cpuid/api.h
> index 44fa82e1267c..2b9750cc8a75 100644
> --- a/arch/x86/include/asm/cpuid/api.h
> +++ b/arch/x86/include/asm/cpuid/api.h
> @@ -131,12 +131,12 @@ static inline void __cpuid_read(u32 leaf, u32 subleaf, u32 *regs)
>  	__cpuid(regs + CPUID_EAX, regs + CPUID_EBX, regs + CPUID_ECX, regs + CPUID_EDX);
>  }
>  
> -#define cpuid_subleaf(leaf, subleaf, regs) {		\
> +#define cpuid_read_subleaf(leaf, subleaf, regs) {	\
>  	static_assert(sizeof(*(regs)) == 16);		\
>  	__cpuid_read(leaf, subleaf, (u32 *)(regs));	\
>  }
>  
> -#define cpuid_leaf(leaf, regs) {			\
> +#define cpuid_read(leaf, regs) {			\

Are we getting rid of that "cpuid_read" thing eventually?

Because with CPUID the only thing you can do is read - no write.

That can be sorted out when the dust settles...


-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette