[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <SJ1PR11MB60831185836B9847D314A978FCFDA@SJ1PR11MB6083.namprd11.prod.outlook.com>
Date: Tue, 28 Oct 2025 21:19:14 +0000
From: "Luck, Tony" <tony.luck@...el.com>
To: "Hansen, Dave" <dave.hansen@...el.com>, Peter Zijlstra
<peterz@...radead.org>
CC: "x86@...nel.org" <x86@...nel.org>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>, "patches@...ts.linux.dev"
<patches@...ts.linux.dev>
Subject: RE: [PATCH] x86/cpu: Add/fix core comments for {Panther,Nova} Lake
On 10/28/25 10:29, Tony Luck wrote:
> > -#define INTEL_NOVALAKE IFM(18, 0x01)
> > -#define INTEL_NOVALAKE_L IFM(18, 0x03)
> > +#define INTEL_NOVALAKE IFM(18, 0x01) /* Coyote Cove / Arctic Wolf */
> > +#define INTEL_NOVALAKE_L IFM(18, 0x03) /* Coyote Cove / Arctic Wolf */
>
> Is it even worth keeping the core names in there? This is an example
> where they're causing churn. If nobody cares, maybe we should just
> zap them, or at least stop putting them in there for new CPUs.
PeterZ thought the comments were useful to track CPU model specific places
(like "perf") where multiple Intel CPU models can share the same code.
-Tony
Powered by blists - more mailing lists