linux-kernel - Re: [PATCH v2 03/26] drm/xe/pf: Add save/restore control state stubs and connect to debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3ebd02d1-2a91-4510-8bdc-e3edf7180e18@intel.com>
Date: Tue, 28 Oct 2025 09:02:46 +0100
From: Michal Wajdeczko <michal.wajdeczko@...el.com>
To: "Tian, Kevin" <kevin.tian@...el.com>, "Winiarski, Michal"
	<michal.winiarski@...el.com>, Alex Williamson <alex.williamson@...hat.com>,
	"De Marchi, Lucas" <lucas.demarchi@...el.com>,
	Thomas Hellström <thomas.hellstrom@...ux.intel.com>, "Vivi,
 Rodrigo" <rodrigo.vivi@...el.com>, Jason Gunthorpe <jgg@...pe.ca>, "Yishai
 Hadas" <yishaih@...dia.com>, "intel-xe@...ts.freedesktop.org"
	<intel-xe@...ts.freedesktop.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	"Brost, Matthew" <matthew.brost@...el.com>
CC: "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>, "Jani
 Nikula" <jani.nikula@...ux.intel.com>, Joonas Lahtinen
	<joonas.lahtinen@...ux.intel.com>, Tvrtko Ursulin <tursulin@...ulin.net>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, "Laguna,
 Lukasz" <lukasz.laguna@...el.com>
Subject: Re: [PATCH v2 03/26] drm/xe/pf: Add save/restore control state stubs
 and connect to debugfs



On 10/28/2025 4:06 AM, Tian, Kevin wrote:
>> From: Winiarski, Michal <michal.winiarski@...el.com>
>> Sent: Wednesday, October 22, 2025 6:41 AM
>>
>> +int xe_gt_sriov_pf_control_trigger_save_vf(struct xe_gt *gt, unsigned int
>> vfid)
> 
> the prefix is too long. xe_gt_sriov_trigger_save_vf() or
> xe_gt_trigger_save_vf() is sufficient. 

on the Xe driver we name functions based on the sub-component name

xe_sriov_vfio.c
	= xe|sriov|vfio
	= Xe driver | SR-IOV feature | VFIO interface

xe_sriov_pf_control.c
	= xe|sriov|pf|control
	= Xe driver | SR-IOV feature | PF specific | control

xe_gt_sriov_pf_control.c
	= xe|gt|sriov|pf|control
	= Xe driver | GT-related | SR-IOV feature | PF specific | control

and only functions from the xe|sriov|vfio component will be exported
for use by the xe vfio driver (hence the vfio tag in their names) and
other functions will be internal to the Xe driver