linux-kernel - Re: [PATCH v5 1/7] media: platform: amd: Introduce amd isp4 capture driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7b20fb08-fa96-4bd9-8240-05b7f8f31681@amd.com>
Date: Tue, 28 Oct 2025 17:00:48 +0800
From: "Du, Bin" <bin.du@....com>
To: Krzysztof Kozlowski <krzk@...nel.org>, mchehab@...nel.org,
 hverkuil@...all.nl, laurent.pinchart+renesas@...asonboard.com,
 bryan.odonoghue@...aro.org, sakari.ailus@...ux.intel.com,
 prabhakar.mahadev-lad.rj@...renesas.com, linux-media@...r.kernel.org,
 linux-kernel@...r.kernel.org, sultan@...neltoast.com
Cc: pratap.nirujogi@....com, benjamin.chan@....com, king.li@....com,
 gjorgji.rosikopulos@....com, Phil.Jawich@....com, Dominic.Antony@....com,
 mario.limonciello@....com, richard.gong@....com, anson.tsao@....com,
 Mario Limonciello <superm1@...nel.org>,
 Alexey Zagorodnikov <xglooom@...il.com>
Subject: Re: [PATCH v5 1/7] media: platform: amd: Introduce amd isp4 capture
 driver

Thanks Krzysztof.

On 10/28/2025 4:41 PM, Krzysztof Kozlowski wrote:
> On 28/10/2025 09:30, Du, Bin wrote:
>>>> +	}
>>>> +};
>>>> +
>>>> +module_platform_driver(isp4_capture_drv);
>>>> +
>>>> +MODULE_ALIAS("platform:" ISP4_DRV_NAME);
>>>
>>> You should not need MODULE_ALIAS() in normal cases. If you need it,
>>> usually it means your device ID table is wrong (e.g. misses either
>>> entries or MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute
>>> for incomplete ID table.
>>>
>>
>> Thanks for the clarification, yes, MODULE_ALIAS() does not apply in our
>> case and should be removed.
> 
> 
> You don't have ID table, so probably this should be fixed, unless it is
> instantiated by some other driver, e.g. as MFD. That's the only typical
> use case for alias in the drivers.
> 

Yes, our device is a MFD, so alias works for it, as alternative, we can 
add module device table, it should work either, could you please 
indicate your preferred option?

> Best regards,
> Krzysztof

-- 
Regards,
Bin