linux-kernel - Re: [PATCH] nvme: drop bogus nid quirk for multipath devices which passed id test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251029133834.GB14596@lst.de>
Date: Wed, 29 Oct 2025 14:38:34 +0100
From: Christoph Hellwig <hch@....de>
To: Daniel Wagner <dwagner@...e.de>
Cc: Christoph Hellwig <hch@....de>, Daniel Wagner <wagi@...nel.org>,
	Keith Busch <kbusch@...nel.org>,
	John Meneghini <jmeneghi@...hat.com>,
	Bryan Gurney <bgurney@...hat.com>, linux-nvme@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvme: drop bogus nid quirk for multipath devices which
 passed id test

On Wed, Oct 29, 2025 at 11:14:27AM +0100, Daniel Wagner wrote:
> On Wed, Oct 29, 2025 at 10:59:07AM +0100, Christoph Hellwig wrote:
> > The problem is that there is no such thing as a sanity check.  Otherwise
> > life would be easy.  But I really can't believe that Dell is incompetent
> > enough to not leave a mark of their OEM Firmware version anywhere.
> 
> Got it. Sure, there are version strings though not really 'stable' as
> Hannes told me. Maybe there is a way to filter these out. But isn't this
> what the command line idea overwrite feature is?

Version isn't optimal, but model numbers often encode model numbers,
and some devices have identifiers in the vendor specific regions of
identify commands.

> John, did you have some progress with this?
> 
> The sad thing is that the Intel device needs the quirk. If the Dell
> device just would use it's own IDs...

I'm pretty sure they are one and the same device, just with slightly
different firmware versions.  It might be that Dell actually reported
the bogus IDs to Intel as part of compliance testing and Intel only
fixed it for them and not the generic firmware build :(