linux-kernel - Re: [PATCH] nvme: drop bogus nid quirk for multipath devices which passed id test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <15c974ec-dd78-4344-bd90-f30f4bb7da49@suse.de>
Date: Wed, 5 Nov 2025 08:33:20 +0100
From: Hannes Reinecke <hare@...e.de>
To: Daniel Wagner <wagi@...nel.org>, Keith Busch <kbusch@...nel.org>,
 Christoph Hellwig <hch@....de>
Cc: John Meneghini <jmeneghi@...hat.com>, Bryan Gurney <bgurney@...hat.com>,
 linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org,
 Daniel Wagner <dwagner@...e.de>
Subject: Re: [PATCH] nvme: drop bogus nid quirk for multipath devices which
 passed id test

On 10/28/25 13:54, Daniel Wagner wrote:
> From: Daniel Wagner <dwagner@...e.de>
> 
> Dell Express Flash NVMe P4610 reuse the Intel device id 0x0a54. The
> Intel P4500/46000 device needs NVME_QUIRK_BOBUG_NID whereas the Dell
> does not. Thus clear the quirk when the id check passes.
> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217981
> Signed-off-by: Daniel Wagner <dwagner@...e.de>
> ---
> Hi,
> 
> Obviously, using the correct IDs is really hard. There are at least two devices
> which share a the device id and one needs the bogus id workaround the other
> doesn't.
> 
> We discussed the idea to pass through configuration from the kernel command line
> at ALPSS. I am not sure, how far we got with this yet. What about something like
> this here?
> 
> Thanks,
> Daniel
> 
> Signed-off-by: Daniel Wagner <wagi@...nel.org>
> ---
>   drivers/nvme/host/core.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
Reviewed-by: Hannes Reinecke <hare@...e.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@...e.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich