linux-kernel - Re: [PATCH] arm64: dts: rockchip: include rk3399-base instead of rk3399 in rk3399-op1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f4149b94-30e5-ff0f-44b2-0806b2747890@manjaro.org>
Date: Wed, 29 Oct 2025 15:14:09 +0100
From: "Dragan Simic" <dsimic@...jaro.org>
To: "Quentin Schulz" <foss+kernel@...il.net>
Cc: "Rob Herring" <robh@...nel.org>, "Krzysztof Kozlowski" <krzk+dt@...nel.org>, "Conor Dooley" <conor+dt@...nel.org>, "Heiko Stuebner" <heiko@...ech.de>, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org, "Quentin Schulz" <quentin.schulz@...rry.de>, stable@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: include rk3399-base instead of rk3399 in 
 rk3399-op1

Hello Quentin,

On Wednesday, October 29, 2025 14:50 CET, Quentin Schulz <foss+kernel@...il.net> wrote:
> From: Quentin Schulz <quentin.schulz@...rry.de>
> 
> In commit 296602b8e5f7 ("arm64: dts: rockchip: Move RK3399 OPPs to dtsi
> files for SoC variants"), everything shared between variants of RK3399
> was put into rk3399-base.dtsi and the rest in variant-specific DTSI,
> such as rk3399-t, rk3399-op1, rk3399, etc.
> Therefore, the variant-specific DTSI should include rk3399-base.dtsi and
> not another variant's DTSI.
> 
> rk3399-op1 wrongly includes rk3399 (a variant) DTSI instead of
> rk3399-base DTSI, let's fix this oversight by including the intended
> DTSI.
> 
> Fortunately, this had no impact on the resulting DTB since all nodes
> were named the same and all node properties were overridden in
> rk3399-op1.dtsi. This was checked by doing a checksum of rk3399-op1 DTBs
> before and after this commit.
> 
> No intended change in behavior.

Thank you for spotting this issue and for fixing it!  That was
an honest oversight on my part, but it actually resulted in no
ill effects, which is the main reason why and how it managed to
slip by originally.

Your description of the issue is pretty much perfect, so I've
got nothing else to add but

Reviewed-by: Dragan Simic <dsimic@...jaro.org>

> Fixes: 296602b8e5f7 ("arm64: dts: rockchip: Move RK3399 OPPs to dtsi files for SoC variants")
> Cc: stable@...r.kernel.org
> Signed-off-by: Quentin Schulz <quentin.schulz@...rry.de>
> ---
>  arch/arm64/boot/dts/rockchip/rk3399-op1.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-op1.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-op1.dtsi
> index c4f4f1ff6117b..9da6fd82e46b2 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-op1.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-op1.dtsi
> @@ -3,7 +3,7 @@
>   * Copyright (c) 2016-2017 Fuzhou Rockchip Electronics Co., Ltd
>   */
>  
> -#include "rk3399.dtsi"
> +#include "rk3399-base.dtsi"
>  
>  / {
>  	cluster0_opp: opp-table-0 {