linux-kernel - Re: [PATCH v1 1/2] drm/panel-edp: Add override bpc quirk for generic edp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=X9hUxsrJ6o5yP0-bprfKgyQzZJnQRwQVYRo6G0yKWhCg@mail.gmail.com>
Date: Wed, 29 Oct 2025 16:20:51 -0700
From: Doug Anderson <dianders@...omium.org>
To: Ajye Huang <ajye_huang@...pal.corp-partner.google.com>
Cc: linux-kernel@...r.kernel.org, Neil Armstrong <neil.armstrong@...aro.org>, 
	Jessica Zhang <jesszhan0024@...il.com>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	dri-devel@...ts.freedesktop.org, jazhan@...gle.com, 
	Jani Nikula <jani.nikula@...el.com>
Subject: Re: [PATCH v1 1/2] drm/panel-edp: Add override bpc quirk for generic edp

Hi,

On Wed, Oct 29, 2025 at 1:11 AM Ajye Huang
<ajye_huang@...pal.corp-partner.google.com> wrote:
>
> Adding override bpc to EDP_PANEL_ENTRY3 quirk.
>
> Signed-off-by: Ajye Huang <ajye_huang@...pal.corp-partner.google.com>
> ---
>  drivers/gpu/drm/panel/panel-edp.c | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)

This seems OK to me. I'd be OK with:

Reviewed-by: Douglas Anderson <dianders@...omium.org>

I think you could alternatively add a EDID_QUIRK_FORCE_6BPC quirk for
this panel in "drivers/gpu/drm/drm_edid.c", though I haven't tested
it. That _might_ be a better solution? Maybe Jani or someone else CCed
would have an opinion.

At first I was thinking that the quirks in "drm_edid.c" were probably
just for "DP" display, but then I just realized that they probably
also are for "eDP" panels. Specifically I think Intel hardware doesn't
use panel-edp.c so I think the only place quirks could get applied (if
an eDP panel was also used on Intel hardware) was from "drm_edid.c".

Any chance you could confirm if EDID_QUIRK_FORCE_6BPC works for you?

Does anyone else CCed have an opinion of which they like better?

-Doug