linux-kernel - Re: [PATCH] drm/mediatek: Fix device node reference leak in mtk_dp_dt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DDUNMKXD4HRX.DXUT67S354TJ@baylibre.com>
Date: Wed, 29 Oct 2025 09:14:23 +0100
From: "Markus Schneider-Pargmann" <msp@...libre.com>
To: "Miaoqian Lin" <linmq006@...il.com>, "Chun-Kuang Hu"
 <chunkuang.hu@...nel.org>, "Philipp Zabel" <p.zabel@...gutronix.de>, "David
 Airlie" <airlied@...il.com>, "Simona Vetter" <simona@...ll.ch>, "Matthias
 Brugger" <matthias.bgg@...il.com>, "AngeloGioacchino Del Regno"
 <angelogioacchino.delregno@...labora.com>, "Markus Schneider-Pargmann"
 <msp@...libre.com>, "CK Hu" <ck.hu@...iatek.com>, "Dmitry Osipenko"
 <dmitry.osipenko@...labora.com>, "Guillaume Ranquet"
 <granquet@...libre.com>, <dri-devel@...ts.freedesktop.org>,
 <linux-mediatek@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
 <linux-arm-kernel@...ts.infradead.org>
Cc: <stable@...r.kernel.org>
Subject: Re: [PATCH] drm/mediatek: Fix device node reference leak in
 mtk_dp_dt_parse()

On Wed Oct 29, 2025 at 8:23 AM CET, Miaoqian Lin wrote:
> The function mtk_dp_dt_parse() calls of_graph_get_endpoint_by_regs()
> to get the endpoint device node, but fails to call of_node_put() to release
> the reference when the function returns. This results in a device node
> reference leak.
>
> Fix this by adding the missing of_node_put() call before returning from
> the function.
>
> Found via static analysis and code review.
>
> Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort driver")
> Cc: stable@...r.kernel.org
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>

Reviewed-by: Markus Schneider-Pargmann <msp@...libre.com>

Best
Markus

Download attachment "signature.asc" of type "application/pgp-signature" (290 bytes)