linux-kernel - Re: [PATCH v9 3/3] arm64: dts: qcom: sm8750: Add USB support for SM8750 QRD platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a117b105-a734-4f67-9bb2-c06728e79083@kernel.org>
Date: Wed, 29 Oct 2025 09:07:23 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Krishna Kurapati <krishna.kurapati@....qualcomm.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Wesley Cheng <wesley.cheng@....qualcomm.com>
Subject: Re: [PATCH v9 3/3] arm64: dts: qcom: sm8750: Add USB support for
 SM8750 QRD platform

On 24/10/2025 17:15, Krishna Kurapati wrote:
> From: Wesley Cheng <wesley.cheng@....qualcomm.com>
> 
> Enable USB support on SM8750 QRD variant.  The current definition
> will start the USB controller in peripheral mode by default until
> dependencies are added, such as USB role detection.
> 
> Signed-off-by: Wesley Cheng <wesley.cheng@....qualcomm.com>
> [Krishna: Flattened usb node QRD DTS]
> Signed-off-by: Krishna Kurapati <krishna.kurapati@....qualcomm.com>

NAK.

You ignored every previous tag - multiple reviews and tests, and then...

> ---
>  arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> index 13c7b9664c89..fc5d12bb41a5 100644
> --- a/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8750-qrd.dts
> @@ -1054,3 +1054,25 @@ &ufs_mem_hc {
>  
>  	status = "okay";
>  };
> +
> +&usb_1 {
> +	dr_mode = "peripheral";

You sent something different with issues.

Really, this was a correct patch. Was reviewed. Why you decided to drop
all this, drop everything which was correct?

Your explanation:
"- Removed obtained RB tags since the code has changed significantly."
is just wrong. Almost NOTHING changed, except completely unimportant two
node merging.

NAK

Best regards,
Krzysztof