linux-kernel - Re: [PATCH v2] staging: sm750fb: style fixes: align call and split chained assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025102946-thickness-audacious-5c22@gregkh>
Date: Wed, 29 Oct 2025 11:16:32 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Cristian Del Gobbo <cristiandelgobbo87@...il.com>
Cc: sudip.mukherjee@...il.com, teddy.wang@...iconmotion.com,
	linux-fbdev@...r.kernel.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH v2] staging: sm750fb: style fixes: align call and split
 chained assignment

On Wed, Oct 29, 2025 at 03:14:49AM +0100, Cristian Del Gobbo wrote:
> - Drop previous change that made g_fbmode[] elements const (broke build).
> - Align the continued arguments of sm750_hw_cursor_set_size() with the
>   opening parenthesis.
> - Replace a chained assignment of red/green/blue with a temporary
>   variable to satisfy checkpatch and improve readability.
> 
> No functional change intended.
> 
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> Signed-off-by: Cristian Del Gobbo <cristiandelgobbo87@...il.com>
> ---
>  drivers/staging/sm750fb/sm750.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)

On top of what Dan said, I see 4 different copies of this patch in my
inbox, which one is the correct one?  Please make it easy for
maintainers to know what patch to review, we get 1000+ emails a day to
deal with and have no short term memory :)

thanks,

greg k-h