linux-kernel - Re: [PATCH 2/3] slab: convert setup_slub_debug() to use __core_param

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aQHpatjGesXvwMBj@hyeyoo>
Date: Wed, 29 Oct 2025 19:16:10 +0900
From: Harry Yoo <harry.yoo@...cle.com>
To: Petr Tesarik <ptesarik@...e.com>
Cc: Vlastimil Babka <vbabka@...e.cz>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Christoph Lameter <cl@...two.org>,
        David Rientjes <rientjes@...gle.com>,
        Roman Gushchin <roman.gushchin@...ux.dev>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] slab: convert setup_slub_debug() to use
 __core_param_cb()

On Fri, Oct 24, 2025 at 07:06:53PM +0200, Petr Tesarik wrote:
> Use __core_param_cb() to parse the "slab_debug" kernel parameter instead of
> the obsolescent __setup(). For now, the parameter is not exposed in sysfs,
> and no get ops is provided.
> 
> There is a slight change in behavior. Before this patch, the following
> parameter would silently turn on full debugging for all slabs:
> 
>   slub_debug_yada_yada_gotta_love_this=hail_satan!
> 
> This syntax is now rejected, and the parameter will be passed to user
> space, making the kernel a holier place.
> 
> Signed-off-by: Petr Tesarik <ptesarik@...e.com>
> ---

Good byte to slub_debug_yada_yada_gotta_love_this=hail_satan! :'(

Looks good to me,
Reviewed-by: Harry Yoo <harry.yoo@...cle.com>

-- 
Cheers,
Harry / Hyeonggon