linux-kernel - Re: [PATCH 2/2] riscv: Remove redundant judgment for the default build target

Open Source and information security mailing list archives

Message-ID: <CAJM55Z8c5fy4Gy+6JRy_p4=4sbMuGbKyNMQB4cwUdNLcFjgLEQ@mail.gmail.com>
Date: Wed, 29 Oct 2025 03:44:26 -0700
From: Emil Renner Berthing <emil.renner.berthing@...onical.com>
To: Feng Jiang <jiangfeng@...inos.cn>, alex@...ti.fr, aou@...s.berkeley.edu, 
	masahiroy@...nel.org, nicolas.schier@...ux.dev, palmer@...belt.com, 
	pjw@...nel.org
Cc: linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] riscv: Remove redundant judgment for the default
 build target

Quoting Feng Jiang (2025-10-29 10:44:29)
> The value of KBUILD_IMAGE is derived from $(boot-image-y),
> so there's no need for redundant checks before this.
>
> Signed-off-by: Feng Jiang <jiangfeng@...inos.cn>
> ---
>  arch/riscv/Makefile | 15 ---------------
>  1 file changed, 15 deletions(-)
>
> diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile
> index 3998d4036f15..4c6de57f65ef 100644
> --- a/arch/riscv/Makefile
> +++ b/arch/riscv/Makefile
> @@ -134,21 +134,6 @@ endif
>  CHECKFLAGS += -D__riscv -D__riscv_xlen=$(BITS)
>
>  # Default target when executing plain make
> -boot           := arch/riscv/boot
> -ifeq ($(CONFIG_XIP_KERNEL),y)
> -KBUILD_IMAGE := $(boot)/xipImage
> -else
> -ifeq ($(CONFIG_RISCV_M_MODE)$(CONFIG_SOC_CANAAN_K210),yy)
> -KBUILD_IMAGE := $(boot)/loader.bin
> -else
> -ifeq ($(CONFIG_EFI_ZBOOT),)
> -KBUILD_IMAGE   := $(boot)/Image.gz
> -else
> -KBUILD_IMAGE := $(boot)/vmlinuz.efi
> -endif
> -endif
> -endif
> -

I think this might be a leftover from a faulty merge. The original patchset
removed this part, so

Reviewed-by: Emil Renner Berthing <emil.renner.berthing@...onical.com>

>  boot                                   := arch/riscv/boot
>  boot-image-y                           := Image
>  boot-image-$(CONFIG_KERNEL_BZIP2)      := Image.bz2
> --
> 2.25.1
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives