linux-kernel - Re: [PATCH] HID: nintendo: Reduce JC_SUBCMD_RATE_MAX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEVj2tkow09F0CpnWBy1CqyC_CGTqkPkH4geNgCGn5R_ZGD9TQ@mail.gmail.com>
Date: Thu, 30 Oct 2025 13:44:05 -0400
From: Daniel Ogorchock <djogorchock@...il.com>
To: Willy Huang <willyhuang@...gle.com>
Cc: Jiri Kosina <jikos@...nel.org>, Benjamin Tissoires <bentiss@...nel.org>, linux-input@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: nintendo: Reduce JC_SUBCMD_RATE_MAX_ATTEMPTS

Hi Willy,

On Thu, Oct 30, 2025 at 2:37 AM Willy Huang <willyhuang@...gle.com> wrote:
>
> The JC_SUBCMD_RATE_MAX_ATTEMPTS constant is currently set to 500.
> In a worst-case scenario where all attempts consistently fail, this could
> cause the loop to block for up to 60000 ms (500 * 60ms * 2, including the
> additional retry after a timeout).
>
> This change lowers the maximum potential blocking time to 3000 ms
> (25 * 60ms * 2), improving system responsiveness and efficiency.
>
> Signed-off-by: Willy Huang <willyhuang@...gle.com>
> ---
>  drivers/hid/hid-nintendo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-nintendo.c b/drivers/hid/hid-nintendo.c
> index c2849a541f65..342cd6893502 100644
> --- a/drivers/hid/hid-nintendo.c
> +++ b/drivers/hid/hid-nintendo.c
> @@ -819,7 +819,7 @@ static void joycon_wait_for_input_report(struct joycon_ctlr *ctlr)
>  #define JC_INPUT_REPORT_MAX_DELTA      17
>  #define JC_SUBCMD_TX_OFFSET_MS         4
>  #define JC_SUBCMD_VALID_DELTA_REQ      3
> -#define JC_SUBCMD_RATE_MAX_ATTEMPTS    500
> +#define JC_SUBCMD_RATE_MAX_ATTEMPTS    25
>  #define JC_SUBCMD_RATE_LIMITER_USB_MS  20
>  #define JC_SUBCMD_RATE_LIMITER_BT_MS   60
>  #define JC_SUBCMD_RATE_LIMITER_MS(ctlr)        ((ctlr)->hdev->bus == BUS_USB ? JC_SUBCMD_RATE_LIMITER_USB_MS : JC_SUBCMD_RATE_LIMITER_BT_MS)
> --
> 2.51.1.851.g4ebd6896fd-goog
>

Thanks for the patch. Seems like a good change.

Reviewed-by: Daniel J. Ogorchock <djogorchock@...il.com>

- Daniel