linux-kernel - Re: [PATCH v3 1/6] dt-bindings: arm: fsl: Add GOcontroll Moduline IV/Mini

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251030-unfailing-venue-e27a74ebab2d@spud>
Date: Thu, 30 Oct 2025 18:34:49 +0000
From: Conor Dooley <conor@...nel.org>
To: maudspierings@...ontroll.com
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	Matti Vaittinen <mazziesaccount@...il.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 1/6] dt-bindings: arm: fsl: Add GOcontroll Moduline
 IV/Mini

On Thu, Oct 30, 2025 at 07:35:37AM +0100, Maud Spierings via B4 Relay wrote:
> From: Maud Spierings <maudspierings@...ontroll.com>
> 
> Document the compatible strings for the Moduline IV and Mini.

> Also add a compatible for the Ka-Ro Electronics TX8M-1610

This is not very helpful to say, makes what you've done seem accidental.
I assumed this was wrong, until I looked up this device and found out it
was a SoM. Please put that in the commit message.
With that info,
Acked-by: Conor Dooley <conor.dooley@...rochip.com>
pw-bot: changes-requested

> 
> Signed-off-by: Maud Spierings <maudspierings@...ontroll.com>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 00cdf490b0620..15000923b648a 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -996,6 +996,14 @@ properties:
>            - const: engicam,icore-mx8mm             # i.MX8MM Engicam i.Core MX8M Mini SoM
>            - const: fsl,imx8mm
>  
> +      - description: Ka-Ro Electronics TX8M-1610 based boards
> +        items:
> +          - enum:
> +              - gocontroll,moduline-iv-306-d
> +              - gocontroll,moduline-mini-111
> +          - const: karo,imx8mm-tx8m-1610
> +          - const: fsl,imx8mm
> +
>        - description: Kontron BL i.MX8MM (N801X S) Board
>          items:
>            - const: kontron,imx8mm-bl
> 
> -- 
> 2.51.2
> 
> 
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)