linux-kernel - Re: [PATCH v3 1/6] dt-bindings: arm: fsl: Add GOcontroll Moduline IV/Mini

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <90911798-b692-4bd0-9efe-50268ff8bee6@gocontroll.com>
Date: Fri, 31 Oct 2025 07:46:45 +0100
From: Maud Spierings <maudspierings@...ontroll.com>
To: Conor Dooley <conor@...nel.org>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>,
 Matti Vaittinen <mazziesaccount@...il.com>,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 1/6] dt-bindings: arm: fsl: Add GOcontroll Moduline
 IV/Mini

Hi Conor

On 10/30/25 19:34, Conor Dooley wrote:
> On Thu, Oct 30, 2025 at 07:35:37AM +0100, Maud Spierings via B4 Relay wrote:
>> From: Maud Spierings <maudspierings@...ontroll.com>
>>
>> Document the compatible strings for the Moduline IV and Mini.
> 
>> Also add a compatible for the Ka-Ro Electronics TX8M-1610
> 
> This is not very helpful to say, makes what you've done seem accidental.
> I assumed this was wrong, until I looked up this device and found out it
> was a SoM. Please put that in the commit message.
> With that info,
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> pw-bot: changes-requested
> 

Thanks for the review, new commit message will be:

Document the compatible strings for the Moduline IV and Mini.

Also add a compatible for the Ka-Ro Electronics TX8M-1610 SoM which they 
are based on.

---
Kind regards,
Maud