linux-kernel - Re: [PATCH 4/4] ASoC: dt-bindings: qcom,lpass-va-macro: Add sm6115 LPASS VA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251030-flat-elated-pony-de74ab@kuoka>
Date: Thu, 30 Oct 2025 07:30:06 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>
Cc: robh@...nel.org, broonie@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org, devicetree@...r.kernel.org, perex@...ex.cz, tiwai@...e.com, 
	srini@...nel.org, linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-msm@...r.kernel.org, alexey.klimov@...aro.org
Subject: Re: [PATCH 4/4] ASoC: dt-bindings: qcom,lpass-va-macro: Add sm6115
 LPASS VA

On Wed, Oct 29, 2025 at 04:01:01PM +0000, Srinivas Kandagatla wrote:
> Add bindings for Qualcomm SM6115 SoC Low Power Audio SubSystem (LPASS)
> VA macro codec, which looks like compatible with SM8450, however one of
> the clocks macro is available in this SoC. So updated the bindings to

is or is not? Which clock?

> allow min-clocks to be 3 to be able to use SM8450 compatible for
> SM6115.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>
> ---
>  .../devicetree/bindings/sound/qcom,lpass-va-macro.yaml | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
> index 5b450f227b70..1ac3392776ca 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
> @@ -26,6 +26,10 @@ properties:
>                - qcom,sm8750-lpass-va-macro
>                - qcom,x1e80100-lpass-va-macro
>            - const: qcom,sm8550-lpass-va-macro
> +      - items:
> +          - enum:
> +              - qcom,sm6115-lpass-va-macro
> +          - const: qcom,sm8450-lpass-va-macro
>  
>    reg:
>      maxItems: 1
> @@ -44,9 +48,9 @@ properties:
>      minItems: 1
>      items:
>        - const: mclk
> -      - const: macro

No, that's ABI break and I know existing code works fine, so there
cannot be justification for exception here.


Best regards,
Krzysztof