| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <3fefecd4-e6d5-4804-9e42-76078db620ff@oss.qualcomm.com>
Date: Thu, 30 Oct 2025 08:55:46 +0000
From: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>
Cc: robh@...nel.org, broonie@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, devicetree@...r.kernel.org, perex@...ex.cz,
tiwai@...e.com, srini@...nel.org, linux-sound@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
alexey.klimov@...aro.org
Subject: Re: [PATCH 4/4] ASoC: dt-bindings: qcom,lpass-va-macro: Add sm6115
LPASS VA
On 10/30/25 6:30 AM, Krzysztof Kozlowski wrote:
> On Wed, Oct 29, 2025 at 04:01:01PM +0000, Srinivas Kandagatla wrote:
>> Add bindings for Qualcomm SM6115 SoC Low Power Audio SubSystem (LPASS)
>> VA macro codec, which looks like compatible with SM8450, however one of
>> the clocks macro is available in this SoC. So updated the bindings to
>
> is or is not? Which clock?
typo.
macro clock. is not available.
Existing dt-bindings need some cleanup to be able to add a dedicated
entry for sm6115. Will do that in v2.
>
>> allow min-clocks to be 3 to be able to use SM8450 compatible for
>> SM6115.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>
>> ---
>> .../devicetree/bindings/sound/qcom,lpass-va-macro.yaml | 10 +++++++---
>> 1 file changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
>> index 5b450f227b70..1ac3392776ca 100644
>> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
>> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
>> @@ -26,6 +26,10 @@ properties:
>> - qcom,sm8750-lpass-va-macro
>> - qcom,x1e80100-lpass-va-macro
>> - const: qcom,sm8550-lpass-va-macro
>> + - items:
>> + - enum:
>> + - qcom,sm6115-lpass-va-macro
>> + - const: qcom,sm8450-lpass-va-macro
>>
>> reg:
>> maxItems: 1
>> @@ -44,9 +48,9 @@ properties:
>> minItems: 1
>> items:
>> - const: mclk
>> - - const: macro
>
> No, that's ABI break and I know existing code works fine, so there
> cannot be justification for exception here.
I agree, I did not want va macro to divert from other macros which is
why I was trying to accommodate this under sm8450.
We can add a dedicated compatible for sm6115 for va too, and update the
codec driver.
the dt bindings need to be cleaned up similar to what we did for
rx-macro to be able to accommodate the change in clocks for sm6115.
something like this:
--- a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
@@ -14,6 +14,7 @@ properties:
oneOf:
- enum:
- qcom,sc7280-lpass-va-macro
+ - qcom,sm6115-lpass-va-macro
- qcom,sm8250-lpass-va-macro
- qcom,sm8450-lpass-va-macro
- qcom,sm8550-lpass-va-macro
@@ -42,11 +43,7 @@ properties:
clock-names:
minItems: 1
- items:
- - const: mclk
- - const: macro
- - const: dcodec
- - const: npl
+ maxItems: 4
clock-output-names:
maxItems: 1
@@ -70,50 +67,55 @@ required:
- compatible
- reg
- "#sound-dai-cells"
- - clock-names
- - clocks
allOf:
- $ref: dai-common.yaml#
-
- if:
properties:
compatible:
contains:
@@ -70,50 +67,55 @@ required:
- compatible
- reg
- "#sound-dai-cells"
- - clock-names
- - clocks
allOf:
- $ref: dai-common.yaml#
-
- if:
properties:
compatible:
contains:
const: qcom,sc7280-lpass-va-macro
-
then:
- if:
- required:
- - power-domains
- then:
- properties:
- clocks:
- maxItems: 1
- clock-names:
- maxItems: 1
- else:
- properties:
- clocks:
- minItems: 3
- maxItems: 3
- clock-names:
- minItems: 3
- maxItems: 3
-
+ properties:
+ clock-names:
+ oneOf:
+ - items: # for ADSP based platforms
+ - const: mclk
+ - const: macro
+ - const: dcodec
+ - items: # for ADSP bypass based platforms
+ - const: mclk
- if:
properties:
compatible:
contains:
- const: qcom,sm8250-lpass-va-macro
+ enum:
+ - qcom,sm6115-lpass-va-macro
then:
properties:
clocks:
minItems: 3
maxItems: 3
clock-names:
+ items:
+ - const: mclk
+ - const: dcodec
+ - const: npl
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: qcom,sm8250-lpass-va-macro
+ then:
+ properties:
+ clocks:
minItems: 3
maxItems: 3
+ clock-names:
+ items:
+ - const: mclk
+ - const: macro
+ - const: dcodec
- if:
properties:
@@ -128,8 +130,11 @@ allOf:
minItems: 4
maxItems: 4
clock-names:
- minItems: 4
- maxItems: 4
+ items:
+ - const: mclk
+ - const: macro
+ - const: dcodec
+ - const: npl
- if:
properties:
@@ -143,8 +148,10 @@ allOf:
minItems: 3
maxItems: 3
clock-names:
- minItems: 3
- maxItems: 3
+ items:
+ - const: mclk
+ - const: macro
+ - const: dcodec
unevaluatedProperties: false
>
>
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists