linux-kernel - Re: [PATCH v2 1/2] accel/ivpu: replace use of system_unbound_wq with system_dfl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <485ced4a-78bb-48a7-9494-b9705db9b650@linux.intel.com>
Date: Thu, 30 Oct 2025 08:46:04 +0100
From: Karol Wachowski <karol.wachowski@...ux.intel.com>
To: Marco Crivellari <marco.crivellari@...e.com>,
 linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Cc: Tejun Heo <tj@...nel.org>, Lai Jiangshan <jiangshanlai@...il.com>,
 Frederic Weisbecker <frederic@...nel.org>,
 Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
 Michal Hocko <mhocko@...e.com>,
 Maciej Falkowski <maciej.falkowski@...ux.intel.com>,
 Oded Gabbay <ogabbay@...nel.org>
Subject: Re: [PATCH v2 1/2] accel/ivpu: replace use of system_unbound_wq with
 system_dfl_wq

On 10/29/2025 9:01 PM, Karol Wachowski wrote:
> On 10/29/2025 5:56 PM, Marco Crivellari wrote:
>> Currently if a user enqueue a work item using schedule_delayed_work() the
>> used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
>> WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
>> schedule_work() that is using system_wq and queue_work(), that makes use
>> again of WORK_CPU_UNBOUND.
>>
>> This lack of consistency cannot be addressed without refactoring the API.
>>
>> system_unbound_wq should be the default workqueue so as not to enforce
>> locality constraints for random work whenever it's not required.
>>
>> Adding system_dfl_wq to encourage its use when unbound work should be used.
>>
>> The old system_unbound_wq will be kept for a few release cycles.
>>
>> Suggested-by: Tejun Heo <tj@...nel.org>
>> Signed-off-by: Marco Crivellari <marco.crivellari@...e.com>
>> ---
>>  drivers/accel/ivpu/ivpu_pm.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/accel/ivpu/ivpu_pm.c b/drivers/accel/ivpu/ivpu_pm.c
>> index 475ddc94f1cf..ffa2ba7cafe2 100644
>> --- a/drivers/accel/ivpu/ivpu_pm.c
>> +++ b/drivers/accel/ivpu/ivpu_pm.c
>> @@ -186,7 +186,7 @@ void ivpu_pm_trigger_recovery(struct ivpu_device *vdev, const char *reason)
>>  	if (atomic_cmpxchg(&vdev->pm->reset_pending, 0, 1) == 0) {
>>  		ivpu_hw_diagnose_failure(vdev);
>>  		ivpu_hw_irq_disable(vdev); /* Disable IRQ early to protect from IRQ storm */
>> -		queue_work(system_unbound_wq, &vdev->pm->recovery_work);
>> +		queue_work(system_dfl_wq, &vdev->pm->recovery_work);
>>  	}
>>  }
> Reviewed-by: Karol Wachowski <karol.wachowski@...ux.intel.com>
>>  
Pushed to drm-misc-next.
-Karol