linux-kernel - Re: [PATCH] mei: bus: Add newline to sysfs attribute outputs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <83d8d2bb-767a-4dd6-8e1b-de96164cad4c@oss.qualcomm.com>
Date: Thu, 30 Oct 2025 21:11:34 +0800
From: Zhongqiu Han <zhongqiu.han@....qualcomm.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: alexander.usyskin@...el.com, arnd@...db.de, linux-kernel@...r.kernel.org,
        zhongqiu.han@....qualcomm.com
Subject: Re: [PATCH] mei: bus: Add newline to sysfs attribute outputs

On 10/30/2025 8:32 PM, Greg KH wrote:
> On Thu, Oct 30, 2025 at 08:30:00PM +0800, Zhongqiu Han wrote:
>> Append newline characters to sysfs_emit() outputs in func max_conn_show(),
>> fixed_show(), and vtag_show(). This aligns with common kernel conventions
>> and improves readability for userspace tools that expect
>> newline-terminated values.
> 
> What userspace tool reads these values today?  Will this user/kernel api
> break them?  How was this tested?
> 
> thanks,
> 
> greg k-h

Hi Greg,
Thanks for your review~

Apologies for the confusion in the commit message — there isn't
actually a userspace tool that depends on the newline in this case. I
just made the change to follow common sysfs formatting practices and
improve consistency.

If you'd prefer the patch to be dropped or revised, I will proceed
accordingly.

-- 
Thx and BRs,
Zhongqiu Han