linux-kernel - Re: [PATCH] mei: bus: Add newline to sysfs attribute outputs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025110319-activist-register-d119@gregkh>
Date: Mon, 3 Nov 2025 09:25:52 +0900
From: Greg KH <gregkh@...uxfoundation.org>
To: Zhongqiu Han <zhongqiu.han@....qualcomm.com>
Cc: alexander.usyskin@...el.com, arnd@...db.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mei: bus: Add newline to sysfs attribute outputs

On Thu, Oct 30, 2025 at 09:11:34PM +0800, Zhongqiu Han wrote:
> On 10/30/2025 8:32 PM, Greg KH wrote:
> > On Thu, Oct 30, 2025 at 08:30:00PM +0800, Zhongqiu Han wrote:
> > > Append newline characters to sysfs_emit() outputs in func max_conn_show(),
> > > fixed_show(), and vtag_show(). This aligns with common kernel conventions
> > > and improves readability for userspace tools that expect
> > > newline-terminated values.
> > 
> > What userspace tool reads these values today?  Will this user/kernel api
> > break them?  How was this tested?
> > 
> > thanks,
> > 
> > greg k-h
> 
> Hi Greg,
> Thanks for your review~
> 
> Apologies for the confusion in the commit message — there isn't
> actually a userspace tool that depends on the newline in this case. I
> just made the change to follow common sysfs formatting practices and
> improve consistency.

That's fine, but please work with the people that wrote the tools that
depend on these files today to verify it will not break anything, and
then resubmit the patch with that information in the changelog.

thanks,

greg k-h