linux-kernel - RE: [PATCH v2 03/13] serial: sh-sci: Drop extra lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TY3PR01MB11346985328E37A14287CB3B986F8A@TY3PR01MB11346.jpnprd01.prod.outlook.com>
Date: Fri, 31 Oct 2025 07:08:24 +0000
From: Biju Das <biju.das.jz@...renesas.com>
To: Hugo Villeneuve <hugo@...ovil.com>, biju.das.au <biju.das.au@...il.com>
CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby
	<jirislaby@...nel.org>, wsa+renesas <wsa+renesas@...g-engineering.com>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>, Geert
 Uytterhoeven <geert+renesas@...der.be>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-serial@...r.kernel.org"
	<linux-serial@...r.kernel.org>, "linux-renesas-soc@...r.kernel.org"
	<linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH v2 03/13] serial: sh-sci: Drop extra lines



> -----Original Message-----
> From: Biju Das
> Sent: 31 October 2025 07:07
> To: 'Hugo Villeneuve' <hugo@...ovil.com>; biju.das.au <biju.das.au@...il.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>; Jiri Slaby <jirislaby@...nel.org>; wsa+renesas
> <wsa+renesas@...g-engineering.com>; Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>;
> Geert Uytterhoeven <geert+renesas@...der.be>; linux-kernel@...r.kernel.org; linux-
> serial@...r.kernel.org; linux-renesas-soc@...r.kernel.org
> Subject: RE: [PATCH v2 03/13] serial: sh-sci: Drop extra lines
> 
> Hi Hugo,
> 
> > -----Original Message-----
> > From: Hugo Villeneuve <hugo@...ovil.com>
> > Sent: 30 October 2025 20:22
> > Subject: Re: [PATCH v2 03/13] serial: sh-sci: Drop extra lines
> >
> > Hi Biju,
> >
> > On Thu, 30 Oct 2025 17:57:51 +0000
> > Biju <biju.das.au@...il.com> wrote:
> >
> > > From: Biju Das <biju.das.jz@...renesas.com>
> > >
> > > Shorten the number lines in sci_init_clocks() by fitting the error
> > > messages within an 100-character length limit.
> > >
> > > Signed-off-by: Biju Das <biju.das.jz@...renesas.com>
> > > ---
> > > v1->v2:
> > >  * Updated commit message 80-character->100-character.
> > >  * Increased line limit for error messages to 100-column limit.
> > > ---
> > >  drivers/tty/serial/sh-sci.c | 13 ++++---------
> > >  1 file changed, 4 insertions(+), 9 deletions(-)
> > >
> > > diff --git a/drivers/tty/serial/sh-sci.c
> > > b/drivers/tty/serial/sh-sci.c index b33894d0273b..e9345f898224
> > > 100644
> > > --- a/drivers/tty/serial/sh-sci.c
> > > +++ b/drivers/tty/serial/sh-sci.c
> > > @@ -3008,11 +3008,8 @@ static int sci_init_clocks(struct sci_port *sci_port, struct device *dev)
> > >  			return PTR_ERR(clk);
> > >
> > >  		if (!clk && sci_port->type == SCI_PORT_RSCI &&
> > > -		    (i == SCI_FCK || i == SCI_BRG_INT)) {
> > > -			return dev_err_probe(dev, -ENODEV,
> > > -					     "failed to get %s\n",
> > > -					     name);
> > > -		}
> > > +		    (i == SCI_FCK || i == SCI_BRG_INT))
> > > +			return dev_err_probe(dev, -ENODEV, "failed to get %s\n", name);
> > >
> > >  		if (!clk && i == SCI_FCK) {
> > >  			/*
> > > @@ -3022,16 +3019,14 @@ static int sci_init_clocks(struct sci_port *sci_port, struct device *dev)
> > >  			 */
> > >  			clk = devm_clk_get(dev, "peripheral_clk");
> > >  			if (IS_ERR(clk))
> > > -				return dev_err_probe(dev, PTR_ERR(clk),
> > > -						     "failed to get %s\n",
> > > +				return dev_err_probe(dev, PTR_ERR(clk), "failed to get %s\n",
> > >  						     name);
> >
> > This one can also be on one line (99 characters).
> 
> It is 101 characters.

Sorry, 100 Characters. Let me run checkpatch to see, it generates warning.

Cheers,
Biju