linux-kernel - Re: [PATCH v3 2/5] drm/nouveau/uvmm: Allow larger pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAgWFh02dw=omW-yiBqZ8S7Q2ka79=5eNicXVhBb7Zz_fEB81g@mail.gmail.com>
Date: Thu, 30 Oct 2025 20:52:19 -0400
From: M Henning <mhenning@...krefraction.com>
To: Mohamed Ahmed <mohamedahmedegypt2001@...il.com>
Cc: linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org, 
	Mary Guillemard <mary@...y.zone>, Faith Ekstrand <faith.ekstrand@...labora.com>, 
	Lyude Paul <lyude@...hat.com>, Danilo Krummrich <dakr@...nel.org>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	nouveau@...ts.freedesktop.org
Subject: Re: [PATCH v3 2/5] drm/nouveau/uvmm: Allow larger pages

On Thu, Oct 30, 2025 at 7:04 PM Mohamed Ahmed
<mohamedahmedegypt2001@...il.com> wrote:
> +static bool
> +op_map_aligned_to_page_shift(const struct drm_gpuva_op_map *op, u8 page_shift)
> +{
> +       u64 non_page_bits = (1ULL << page_shift) - 1;
> +
> +       return op->va.addr & non_page_bits == 0 &&
> +              op->va.range & non_page_bits == 0 &&
> +              op->gem.offset & non_page_bits == 0;
> +}

As discussed on irc/discord, this is buggy because it needs more
parenthesis 🤦‍♀️