linux-kernel - Re: [PATCH v3 2/5] drm/nouveau/uvmm: Allow larger pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202510311903.wAzY7iCb-lkp@intel.com>
Date: Fri, 31 Oct 2025 20:04:54 +0800
From: kernel test robot <lkp@...el.com>
To: Mohamed Ahmed <mohamedahmedegypt2001@...il.com>,
	linux-kernel@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, dri-devel@...ts.freedesktop.org,
	Mary Guillemard <mary@...y.zone>,
	Faith Ekstrand <faith.ekstrand@...labora.com>,
	Lyude Paul <lyude@...hat.com>, Danilo Krummrich <dakr@...nel.org>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	nouveau@...ts.freedesktop.org,
	Mohamed Ahmed <mohamedahmedegypt2001@...il.com>
Subject: Re: [PATCH v3 2/5] drm/nouveau/uvmm: Allow larger pages

Hi Mohamed,

kernel test robot noticed the following build warnings:

[auto build test WARNING on drm-misc/drm-misc-next]
[also build test WARNING on drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.18-rc3 next-20251031]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Mohamed-Ahmed/drm-nouveau-uvmm-Prepare-for-larger-pages/20251031-070600
base:   git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link:    https://lore.kernel.org/r/20251030230357.45070-3-mohamedahmedegypt2001%40gmail.com
patch subject: [PATCH v3 2/5] drm/nouveau/uvmm: Allow larger pages
config: alpha-randconfig-r064-20251031 (https://download.01.org/0day-ci/archive/20251031/202510311903.wAzY7iCb-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 10.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251031/202510311903.wAzY7iCb-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510311903.wAzY7iCb-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/nouveau/nouveau_uvmm.c: In function 'op_map_aligned_to_page_shift':
>> drivers/gpu/drm/nouveau/nouveau_uvmm.c:462:37: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
     462 |  return op->va.addr & non_page_bits == 0 &&
         |                       ~~~~~~~~~~~~~~^~~~
   drivers/gpu/drm/nouveau/nouveau_uvmm.c:463:38: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
     463 |         op->va.range & non_page_bits == 0 &&
         |                        ~~~~~~~~~~~~~~^~~~
   drivers/gpu/drm/nouveau/nouveau_uvmm.c:464:40: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
     464 |         op->gem.offset & non_page_bits == 0;
         |                          ~~~~~~~~~~~~~~^~~~


vim +462 drivers/gpu/drm/nouveau/nouveau_uvmm.c

   456	
   457	static bool
   458	op_map_aligned_to_page_shift(const struct drm_gpuva_op_map *op, u8 page_shift)
   459	{
   460		u64 non_page_bits = (1ULL << page_shift) - 1;
   461	
 > 462		return op->va.addr & non_page_bits == 0 &&
   463		       op->va.range & non_page_bits == 0 &&
   464		       op->gem.offset & non_page_bits == 0;
   465	}
   466	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki