linux-kernel - Re: [PATCH v3 1/2] dt-bindings: firmware: Add binding for SMBIOS /chosen properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMj1kXGykgmJey8SgGuKBC8DdwnfqYTiop9OMo1UbcRdw=4cNg@mail.gmail.com>
Date: Fri, 31 Oct 2025 10:05:16 +0100
From: Ard Biesheuvel <ardb@...nel.org>
To: adriana <adriana@...sta.com>
Cc: ilias.apalodimas@...aro.org, trini@...sulko.com, robh@...nel.org, 
	krzk@...nel.org, jdelvare@...e.com, frowand.list@...il.com, 
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, vasilykh@...sta.com, 
	arm.ebbr-discuss@....com, boot-architecture@...ts.linaro.org, 
	linux-efi@...r.kernel.org, uefi-discuss@...ts.uefi.org, 
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 1/2] dt-bindings: firmware: Add binding for SMBIOS
 /chosen properties

On Fri, 31 Oct 2025 at 09:52, Ard Biesheuvel <ardb@...nel.org> wrote:
>
> On Fri, 31 Oct 2025 at 09:41, adriana <adriana@...sta.com> wrote:
> >
> > From: Adriana Nicolae <adriana@...sta.com>
> >
> > Signed-off-by: Adriana Nicolae <adriana@...sta.com>
> > ---
> >  .../bindings/firmware/linux,smbios-table.yaml | 26 +++++++++++++++++++
> >  1 file changed, 26 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/firmware/linux,smbios-table.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/firmware/linux,smbios-table.yaml b/Documentation/devicetree/bindings/firmware/linux,smbios-table.yaml
> > new file mode 100644
> > index 000000000000..b78d8ec6025f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/firmware/linux,smbios-table.yaml
> > @@ -0,0 +1,26 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +# Copyright 2025 Arista Networks
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/firmware/linux,smbios-table.yaml#
>
> Should the file name reflect the property? I.e., linux,smbios3-table.yaml
>

And maybe the property should be called linux,smbios3-entrypoint?

Sorry for the bikeshedding but this will be set in stone as soon as we
deploy it so better to get it right the first time.

> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Memory location for SMBIOS table
> > +
> > +description: |
> > +  This property is used in the /chosen node to pass the physical address
> > +  of SMBIOS (System Management BIOS) or DMI (Desktop Management Interface)
> > +  tables from firmware to the kernel. This is typically used on non-EFI
> > +  platforms like ARM/ARM64.
> > +
>
> 'like ARM/ARM64' is both unnecessary and inaccurate, so better to drop it.
>
> > +maintainers:
> > +  - Adriana Nicolae <adriana@...sta.com>
> > +  - Rob Herring <robh+dt@...nel.org>
> > +
> > +properties:
> > +  linux,smbios3-table:
> > +    $ref: /schemas/types.yaml#/definitions/uint64
> > +    description:
> > +      The 64-bit physical address of the SMBIOSv3 entry point structure.
> > +
> > +additionalProperties: true
> > --
> > 2.51.0
> >