linux-kernel - Re: [PATCH v2 0/2] reset: handle RESET_GPIO better to provide the fallback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aQjI1m0yYs2t1hYq@shikoro>
Date: Mon, 3 Nov 2025 16:23:02 +0100
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: linux-renesas-soc@...r.kernel.org,
	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
	linux-kernel@...r.kernel.org,
	Philipp Zabel <p.zabel@...gutronix.de>
Subject: Re: [PATCH v2 0/2] reset: handle RESET_GPIO better to provide the
 fallback

> You removed RFC and entire rationale. Your earlier commit - 690de2902dca
> - is broken. You must not do that.

Wojciech was told to do exactly what he did. Dunno by whom, I trusted
that after seeing the handling code in reset core. Is the required
fallback documented somewhere?

> Broken 690de2902dca leads to this broken patchset, but that is not a
> correct fix. You need to fix the source - revert 690de2902dca, because
> it is obviously wrong. You MUST ave fallback to reset-gpios, that was
> the entire concept how this driver was written.

What is the benefit of having reset-gpios handling in the reset core
optionally and required as a fallback?

What is the drawback of having this tiny driver in the core and provide
the core-based reset-gpios handling as a way to prevent open coded
solutions?

Sure, I can revert the changes to avoid problems for users, and will
probably do so, but it still feels all very strange to me.

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)