linux-kernel - Re: [PATCH] misc: ad525x_dpot: Replace sprintf with sysfs_emit in sysfs_show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025110333-marbled-viewable-0259@gregkh>
Date: Mon, 3 Nov 2025 21:46:32 +0900
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: Michael Hennerich <michael.hennerich@...log.com>,
	Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] misc: ad525x_dpot: Replace sprintf with sysfs_emit in
 sysfs_show_reg

On Mon, Nov 03, 2025 at 01:34:03PM +0100, Thorsten Blum wrote:
> Replace sprintf() with sysfs_emit() in sysfs_show_reg(). sysfs_emit() is
> preferred for formatting sysfs output as it provides better bounds
> checking.  No functional changes.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> Suggested-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  drivers/misc/ad525x_dpot.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/misc/ad525x_dpot.c b/drivers/misc/ad525x_dpot.c
> index 04683b981e54..519f97089a00 100644
> --- a/drivers/misc/ad525x_dpot.c
> +++ b/drivers/misc/ad525x_dpot.c
> @@ -419,7 +419,7 @@ static ssize_t sysfs_show_reg(struct device *dev,
>  	s32 value;
>  
>  	if (reg & DPOT_ADDR_OTP_EN)
> -		return sprintf(buf, "%s\n", str_enabled_disabled(
> +		return sysfs_emit(buf, "%s\n", str_enabled_disabled(
>  			test_bit(DPOT_RDAC_MASK & reg, data->otp_en_mask)));

I did not suggest doing this for existing code at all, it's only needed
for new code, I've said so many times.

sprintf() works just fine here, there's no bug or issue with it.

thanks,

greg k-h