linux-kernel - Re: [PATCH] misc: ad525x_dpot: Replace sprintf with sysfs_emit in sysfs_show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <EDC58257-4D56-464C-B11D-1AEB0B90EE5C@linux.dev>
Date: Mon, 3 Nov 2025 14:11:41 +0100
From: Thorsten Blum <thorsten.blum@...ux.dev>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Michael Hennerich <michael.hennerich@...log.com>,
 Arnd Bergmann <arnd@...db.de>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] misc: ad525x_dpot: Replace sprintf with sysfs_emit in
 sysfs_show_reg

On 3. Nov 2025, at 13:46, Greg Kroah-Hartman wrote:
> On Mon, Nov 03, 2025 at 01:34:03PM +0100, Thorsten Blum wrote:
>> Replace sprintf() with sysfs_emit() in sysfs_show_reg(). sysfs_emit() is
>> preferred for formatting sysfs output as it provides better bounds
>> checking.  No functional changes.
>> 
>> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
>> Suggested-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> ---
>> [...]
> 
> I did not suggest doing this for existing code at all, it's only needed
> for new code, I've said so many times.

You suggested it in [1] for this function when I made another change to
it a few weeks ago. I even replied that there's no coccicheck warning,
and that the sysfs_emit change should probably be a separate patch.

No big deal, but still confusing.

Thanks,
Thorsten

[1] https://lore.kernel.org/lkml/2025082052-crawfish-revisable-7965@gregkh/