linux-kernel - Re: [PATCH v4 2/3] mm: handle poisoning of pfn without struct pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SA1PR12MB7199A46AD4CE574F5200A5A6B0C4A@SA1PR12MB7199.namprd12.prod.outlook.com>
Date: Tue, 4 Nov 2025 17:21:29 +0000
From: Ankit Agrawal <ankita@...dia.com>
To: Michal Hocko <mhocko@...e.com>, Andrew Morton <akpm@...ux-foundation.org>
CC: Aniket Agashe <aniketa@...dia.com>, Vikram Sethi <vsethi@...dia.com>,
	Jason Gunthorpe <jgg@...dia.com>, Matt Ochs <mochs@...dia.com>, Shameer
 Kolothum <skolothumtho@...dia.com>, "linmiaohe@...wei.com"
	<linmiaohe@...wei.com>, "nao.horiguchi@...il.com" <nao.horiguchi@...il.com>,
	"david@...hat.com" <david@...hat.com>, "lorenzo.stoakes@...cle.com"
	<lorenzo.stoakes@...cle.com>, "Liam.Howlett@...cle.com"
	<Liam.Howlett@...cle.com>, "vbabka@...e.cz" <vbabka@...e.cz>,
	"rppt@...nel.org" <rppt@...nel.org>, "surenb@...gle.com" <surenb@...gle.com>,
	"tony.luck@...el.com" <tony.luck@...el.com>, "bp@...en8.de" <bp@...en8.de>,
	"rafael@...nel.org" <rafael@...nel.org>, "guohanjun@...wei.com"
	<guohanjun@...wei.com>, "mchehab@...nel.org" <mchehab@...nel.org>,
	"lenb@...nel.org" <lenb@...nel.org>, "kevin.tian@...el.com"
	<kevin.tian@...el.com>, "alex@...zbot.org" <alex@...zbot.org>, Neo Jia
	<cjia@...dia.com>, Kirti Wankhede <kwankhede@...dia.com>, "Tarun Gupta
 (SW-GPU)" <targupta@...dia.com>, Zhi Wang <zhiw@...dia.com>, Dheeraj Nigam
	<dnigam@...dia.com>, Krishnakant Jaju <kjaju@...dia.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>, "linux-edac@...r.kernel.org"
	<linux-edac@...r.kernel.org>, "Jonathan.Cameron@...wei.com"
	<Jonathan.Cameron@...wei.com>, "ira.weiny@...el.com" <ira.weiny@...el.com>,
	"Smita.KoralahalliChannabasappa@....com"
	<Smita.KoralahalliChannabasappa@....com>, "u.kleine-koenig@...libre.com"
	<u.kleine-koenig@...libre.com>, "peterz@...radead.org"
	<peterz@...radead.org>, "linux-acpi@...r.kernel.org"
	<linux-acpi@...r.kernel.org>, "kvm@...r.kernel.org" <kvm@...r.kernel.org>
Subject: Re: [PATCH v4 2/3] mm: handle poisoning of pfn without struct pages

>> > > Hi Michal, I am trying to replicate what is being done today for non-PFNMAP
>> > > memory failure in __add_to_kill
>> > > (https://github.com/torvalds/linux/blob/master/mm/memory-failure.c#L376).
>> > > For this series, I am inclined to keep it uniform.
>> >
>> > Unless there is a very good reason for this code then I would rather not
>> > rely on an atomic allocation. This just makes the behavior hard to
>> > predict
>>
>> I don't think this was addressed in the v5 series.
>>
>> Yes please, anything we can do to avoid GFP_ATOMIC makes the kernel
>> more reliable.
>
> This could be done on top of the series because as such this is not a
> blocker but it would be really great if we can stop copying a bad code
> and rather get rid of it also in other poisoning code.

Ok sure, I'll create a separate patch to cover that and do the one-by-one
process kill. I think separation might also have an advantage to isolate
regressions if any during verification.