| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <d5df52f7-4ff8-40a2-b0a3-88e9c2e4e52e@kernel.org> Date: Tue, 4 Nov 2025 09:41:16 +0100 From: Krzysztof Kozlowski <krzk@...nel.org> To: André Draszik <andre.draszik@...aro.org>, Tudor Ambarus <tudor.ambarus@...aro.org>, Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, Lee Jones <lee@...nel.org>, Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>, Krzysztof Kozlowski <krzk+dt@...nel.org> Cc: Peter Griffin <peter.griffin@...aro.org>, Will McVicker <willmcvicker@...gle.com>, kernel-team@...roid.com, linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org, linux-gpio@...r.kernel.org Subject: Re: [PATCH v3 11/20] regulator: s2mps11: drop two needless variable initialisations On 03/11/2025 20:14, André Draszik wrote: > The initialisations being removed are needless, as both variables are > being assigned values unconditionally further down. Additionally, doing > this eager init here might lead to preventing the compiler from issuing > a warning if a future code change actually forgets to assign a useful > value in some code path. > > Signed-off-by: André Draszik <andre.draszik@...aro.org> > --- > drivers/regulator/s2mps11.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> Best regards, Krzysztof
Powered by blists - more mailing lists