linux-kernel - Re: [PATCH 1/4] dt-bindings: i3c: Add snps,dev-nack-retry-cnt property to Synopsys I3C master

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b11f90b0-cc1c-4372-b71a-30d34fe0be8c@kernel.org>
Date: Tue, 4 Nov 2025 10:02:53 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: adrianhoyin.ng@...era.com, alexandre.belloni@...tlin.com,
 Frank.Li@....com, wsa+renesas@...g-engineering.com, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, dinguyen@...nel.org,
 linux-i3c@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: i3c: Add snps,dev-nack-retry-cnt
 property to Synopsys I3C master

On 04/11/2025 09:51, adrianhoyin.ng@...era.com wrote:
> From: Adrian Ng Ho Yin <adrianhoyin.ng@...era.com>
> 
> Add a new optional property 'snps,dev-nack-retry-cnt' to the Synopsys
> DesignWare I3C master device tree binding. This property allows
> configuration of the Device NACK Retry count, which determines how many
> times the controller retries a transaction when a slave device responds
> with NACK.
> 
> Valid values range from 0 to 3, with a default of 0

Don't explain us the binding. We can read the source code. You miss
rationale what hardware aspect you are solving, why we should accept this.

> 
> Signed-off-by: Adrian Ng Ho Yin <adrianhoyin.ng@...era.com>

No, because:
1. Not a board property,
2. Most likely deducible from the compatible,


Best regards,
Krzysztof