linux-kernel - Re: [PATCH] greybus: es2: Use pointer from memcpy() call for assignment in output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aQnmfCKoB3FJ5Jz8@hovoldconsulting.com>
Date: Tue, 4 Nov 2025 12:41:48 +0100
From: Johan Hovold <johan@...nel.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: greybus-dev@...ts.linaro.org, Alex Elder <elder@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org,
	Mark Greer <mgreer@...malcreek.com>,
	Miaoqian Lin <linmq006@...il.com>
Subject: Re: [PATCH] greybus: es2: Use pointer from memcpy() call for
 assignment in output_async()

On Fri, Oct 31, 2025 at 07:57:47PM +0100, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Fri, 31 Oct 2025 19:50:39 +0100
> 
> A pointer was assigned to a variable. The same pointer was used for
> the destination parameter of a memcpy() call.
> This function is documented in the way that the same value is returned.
> Thus convert two separate statements into a direct variable assignment for
> the return value from a memory copy action.

Markus, stop sending these kind of crap patches that just wastes other
people's time. You've had a number of maintainers reviewing the latest
batch (including patches which apparently does not even compile) all
telling you the same thing.

> The source code was transformed by using the Coccinelle software.

Since you know how to work with Coccinelle, at least try to come up with
something that fixes actual bugs.

Johan