| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <246ce503-015e-4c2a-b979-24086df2646c@suswa.mountain>
Date: Wed, 5 Nov 2025 17:59:08 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: oe-kbuild@...ts.linux.dev,
Aaron Kling via B4 Relay <devnull+webgeek1234.gmail.com@...nel.org>,
Krzysztof Kozlowski <krzk@...nel.org>,
Thierry Reding <thierry.reding@...il.com>,
Jonathan Hunter <jonathanh@...dia.com>
Cc: lkp@...el.com, oe-kbuild-all@...ts.linux.dev,
linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org,
Aaron Kling <webgeek1234@...il.com>
Subject: Re: [PATCH v6] memory: tegra210: Support interconnect framework
Hi Aaron,
kernel test robot noticed the following build warnings:
url: https://github.com/intel-lab-lkp/linux/commits/Aaron-Kling-via-B4-Relay/memory-tegra210-Support-interconnect-framework/20251028-015017
base: 211ddde0823f1442e4ad052a2f30f050145ccada
patch link: https://lore.kernel.org/r/20251027-t210-actmon-p2-v6-1-1c4bd227d676%40gmail.com
patch subject: [PATCH v6] memory: tegra210: Support interconnect framework
config: arm-randconfig-r071-20251102 (https://download.01.org/0day-ci/archive/20251103/202511030812.rbcbrDyU-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project d2625a438020ad35330cda29c3def102c1687b1b)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
| Closes: https://lore.kernel.org/r/202511030812.rbcbrDyU-lkp@intel.com/
New smatch warnings:
drivers/memory/tegra/tegra210-emc-core.c:1984 tegra210_emc_opp_table_init() warn: passing zero to 'dev_err_probe'
drivers/memory/tegra/tegra210-emc-core.c:1985 tegra210_emc_opp_table_init() warn: missing error code 'err'
Old smatch warnings:
drivers/memory/tegra/tegra210-emc-core.c:1989 tegra210_emc_opp_table_init() warn: passing zero to 'dev_err_probe'
drivers/memory/tegra/tegra210-emc-core.c:1997 tegra210_emc_opp_table_init() warn: passing zero to 'dev_err_probe'
vim +/dev_err_probe +1984 drivers/memory/tegra/tegra210-emc-core.c
7b344327c279ff Aaron Kling 2025-10-27 1958 static int tegra210_emc_opp_table_init(struct tegra210_emc *emc)
7b344327c279ff Aaron Kling 2025-10-27 1959 {
7b344327c279ff Aaron Kling 2025-10-27 1960 u32 hw_version = BIT(tegra_sku_info.soc_speedo_id);
7b344327c279ff Aaron Kling 2025-10-27 1961 struct dev_pm_opp *opp;
7b344327c279ff Aaron Kling 2025-10-27 1962 unsigned long rate;
7b344327c279ff Aaron Kling 2025-10-27 1963 int opp_token, err, max_opps, i;
7b344327c279ff Aaron Kling 2025-10-27 1964
7b344327c279ff Aaron Kling 2025-10-27 1965 err = dev_pm_opp_set_supported_hw(emc->dev, &hw_version, 1);
7b344327c279ff Aaron Kling 2025-10-27 1966 if (err < 0)
7b344327c279ff Aaron Kling 2025-10-27 1967 return dev_err_probe(emc->dev, err, "failed to set OPP supported HW\n");
7b344327c279ff Aaron Kling 2025-10-27 1968
7b344327c279ff Aaron Kling 2025-10-27 1969 opp_token = err;
7b344327c279ff Aaron Kling 2025-10-27 1970
7b344327c279ff Aaron Kling 2025-10-27 1971 err = dev_pm_opp_of_add_table(emc->dev);
7b344327c279ff Aaron Kling 2025-10-27 1972 if (err) {
7b344327c279ff Aaron Kling 2025-10-27 1973 if (err == -ENODEV)
7b344327c279ff Aaron Kling 2025-10-27 1974 dev_err_probe(emc->dev, err,
7b344327c279ff Aaron Kling 2025-10-27 1975 "OPP table not found, please update your device tree\n");
7b344327c279ff Aaron Kling 2025-10-27 1976 else
7b344327c279ff Aaron Kling 2025-10-27 1977 dev_err_probe(emc->dev, err, "failed to add OPP table\n");
7b344327c279ff Aaron Kling 2025-10-27 1978
7b344327c279ff Aaron Kling 2025-10-27 1979 goto put_hw_table;
7b344327c279ff Aaron Kling 2025-10-27 1980 }
7b344327c279ff Aaron Kling 2025-10-27 1981
7b344327c279ff Aaron Kling 2025-10-27 1982 max_opps = dev_pm_opp_get_opp_count(emc->dev);
7b344327c279ff Aaron Kling 2025-10-27 1983 if (max_opps <= 0) {
7b344327c279ff Aaron Kling 2025-10-27 @1984 dev_err_probe(emc->dev, err, "Failed to add OPPs\n");
If max_opps being zero is an error then we need to set the error
then we need to set the error code. If it's not an error, then
we shouldn't print an error code.
7b344327c279ff Aaron Kling 2025-10-27 @1985 goto remove_table;
7b344327c279ff Aaron Kling 2025-10-27 1986 }
7b344327c279ff Aaron Kling 2025-10-27 1987
7b344327c279ff Aaron Kling 2025-10-27 1988 if (emc->num_timings != max_opps) {
7b344327c279ff Aaron Kling 2025-10-27 1989 dev_err_probe(emc->dev, err, "OPP table does not match emc table\n");
7b344327c279ff Aaron Kling 2025-10-27 1990 goto remove_table;
7b344327c279ff Aaron Kling 2025-10-27 1991 }
7b344327c279ff Aaron Kling 2025-10-27 1992
7b344327c279ff Aaron Kling 2025-10-27 1993 for (i = 0; i < emc->num_timings; i++) {
7b344327c279ff Aaron Kling 2025-10-27 1994 rate = emc->timings[i].rate * 1000;
7b344327c279ff Aaron Kling 2025-10-27 1995 opp = dev_pm_opp_find_freq_exact(emc->dev, rate, true);
7b344327c279ff Aaron Kling 2025-10-27 1996 if (IS_ERR(opp)) {
7b344327c279ff Aaron Kling 2025-10-27 1997 dev_err_probe(emc->dev, err, "Rate %lu not found in OPP table\n", rate);
7b344327c279ff Aaron Kling 2025-10-27 1998 goto remove_table;
7b344327c279ff Aaron Kling 2025-10-27 1999 }
7b344327c279ff Aaron Kling 2025-10-27 2000
7b344327c279ff Aaron Kling 2025-10-27 2001 dev_pm_opp_put(opp);
7b344327c279ff Aaron Kling 2025-10-27 2002 }
7b344327c279ff Aaron Kling 2025-10-27 2003
7b344327c279ff Aaron Kling 2025-10-27 2004 dev_info_once(emc->dev, "OPP HW ver. 0x%x, current clock rate %lu MHz\n",
7b344327c279ff Aaron Kling 2025-10-27 2005 hw_version, clk_get_rate(emc->clk) / 1000000);
7b344327c279ff Aaron Kling 2025-10-27 2006
7b344327c279ff Aaron Kling 2025-10-27 2007 return 0;
7b344327c279ff Aaron Kling 2025-10-27 2008
7b344327c279ff Aaron Kling 2025-10-27 2009 remove_table:
7b344327c279ff Aaron Kling 2025-10-27 2010 dev_pm_opp_of_remove_table(emc->dev);
7b344327c279ff Aaron Kling 2025-10-27 2011 put_hw_table:
7b344327c279ff Aaron Kling 2025-10-27 2012 dev_pm_opp_put_supported_hw(opp_token);
7b344327c279ff Aaron Kling 2025-10-27 2013
7b344327c279ff Aaron Kling 2025-10-27 2014 return err;
7b344327c279ff Aaron Kling 2025-10-27 2015 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists