linux-kernel - Re: [PATCH] rtlwifi: rtl8188ee: remove an accidental '-' character

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5c992936-4e7b-4c0a-abfc-0ec0fb9ef9fd@suswa.mountain>
Date: Wed, 5 Nov 2025 17:54:20 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Ping-Ke Shih <pkshih@...ltek.com>
Cc: Harshit Mogalapalli <harshit.m.mogalapalli@...il.com>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] rtlwifi: rtl8188ee: remove an accidental '-' character

On Mon, Nov 03, 2025 at 01:17:07AM +0000, Ping-Ke Shih wrote:
> Dan Carpenter <dan.carpenter@...aro.org> wrote:
> > Sent: Friday, October 31, 2025 9:04 PM
> > The "->allstasleep" variable is a 1 bit bitfield.  It can only be
> > 0 or 1.  This "= -1" assignement was supposed to be "= 1".  This
> > doesn't change how the code works, it's just a cleanup.
> 
> Yes, this patch doesn't change logic at all. However, it looks like existing
> code is wrong, since other places in the same pattern in this driver set to 0.
> More, I check vendor driver which also sets this value to 0.
> 

Ah.  Good.  Thanks.

Could you send that patch and give me a Reported-by tag?

regards,
dan carpenter