linux-kernel - RE: [PATCH] rtlwifi: rtl8188ee: remove an accidental '-' character

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6ebf3019105c4d5b9a3170ce9bcf2ed8@realtek.com>
Date: Thu, 6 Nov 2025 00:47:58 +0000
From: Ping-Ke Shih <pkshih@...ltek.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: Harshit Mogalapalli <harshit.m.mogalapalli@...il.com>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH] rtlwifi: rtl8188ee: remove an accidental '-' character

Dan Carpenter <dan.carpenter@...aro.org> wrote:
> On Mon, Nov 03, 2025 at 01:17:07AM +0000, Ping-Ke Shih wrote:
> > Dan Carpenter <dan.carpenter@...aro.org> wrote:
> > > Sent: Friday, October 31, 2025 9:04 PM
> > > The "->allstasleep" variable is a 1 bit bitfield.  It can only be
> > > 0 or 1.  This "= -1" assignement was supposed to be "= 1".  This
> > > doesn't change how the code works, it's just a cleanup.
> >
> > Yes, this patch doesn't change logic at all. However, it looks like existing
> > code is wrong, since other places in the same pattern in this driver set to 0.
> > More, I check vendor driver which also sets this value to 0.
> >
> 
> Ah.  Good.  Thanks.
> 
> Could you send that patch and give me a Reported-by tag?
> 

Sent by [1].

[1] https://lore.kernel.org/linux-wireless/1762390172-21091-1-git-send-email-pkshih@realtek.com/T/#u