linux-kernel - Re: [PATCH 2/2] iio: accel: adxl380: add support for ADXL318 and ADXL319

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aQtpBGJ0WyWbsQ1Q@smile.fi.intel.com>
Date: Wed, 5 Nov 2025 17:11:00 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Jonathan Santos <Jonathan.Santos@...log.com>
Cc: linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, Michael.Hennerich@...log.com,
	ramona.gradinariu@...log.com, antoniu.miclaus@...log.com,
	jic23@...nel.org, dlechner@...libre.com, nuno.sa@...log.com,
	andy@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org
Subject: Re: [PATCH 2/2] iio: accel: adxl380: add support for ADXL318 and
 ADXL319

On Wed, Nov 05, 2025 at 09:40:34AM -0300, Jonathan Santos wrote:
> The ADXL318 and ADXL319 are low noise density, low power, 3-axis
> accelerometers based on ADXL380 and ADXL382, respectively. The main
> difference between the new parts and the existing ones are the absence
> of interrupts and events like tap detection, activity/inactivity, and
> free-fall detection.
> 
> Other differences in the new parts are fewer power modes, basically
> allowing only idle and measurement modes, and the removal of the 12-bit
> SAR ADC path for the 3-axis signals (known as lower signal chain),
> being excluisive for the temperature sensor in the ADXL318/319.

...

> struct adxl380_chip_info {

>  	const int samp_freq_tbl[3];
>  	const int temp_offset;
>  	const u16 chip_id;
> +	const struct iio_info *info;
> +	const bool has_low_power;
>  };

You can save a few bytes here. Please, run `pahole` to see ways to improve
the layout.

Other than that, LGTM,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...el.com>

-- 
With Best Regards,
Andy Shevchenko