linux-kernel - Re: [PATCH] regulator: qcomm-labibb: replace use of system_wq with system_percpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aQt6pofw-Ub-lEbZ@finisterre.sirena.org.uk>
Date: Wed, 5 Nov 2025 16:26:14 +0000
From: Mark Brown <broonie@...nel.org>
To: Marco Crivellari <marco.crivellari@...e.com>
Cc: linux-kernel@...r.kernel.org, Tejun Heo <tj@...nel.org>,
	Lai Jiangshan <jiangshanlai@...il.com>,
	Frederic Weisbecker <frederic@...nel.org>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Michal Hocko <mhocko@...e.com>, Liam Girdwood <lgirdwood@...il.com>
Subject: Re: [PATCH] regulator: qcomm-labibb: replace use of system_wq with
 system_percpu_wq

On Wed, Nov 05, 2025 at 05:20:24PM +0100, Marco Crivellari wrote:

> Replace system_wq with system_percpu_wq, keeping the old behavior.
> The old wq (system_wq) will be kept for a few release cycles.

As with the ASoC stuff I'm really not convinced that this driver cares
about this being per CPU so we'd be better off just using the unbound
workqueue.  The fact that the existing API was per CPU by default feels
like a bit of a landmine and baking it in explicitly makes the driver
code more confusing.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)