linux-kernel - Re: [PATCH v2 08/12] nova-core: sequencer: Add register opcodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0FF9536C-8740-42C3-8EF1-5C8CD5520E49@nvidia.com>
Date: Wed, 5 Nov 2025 03:45:53 +0000
From: Joel Fernandes <joelagnelf@...dia.com>
To: John Hubbard <jhubbard@...dia.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"rust-for-linux@...r.kernel.org" <rust-for-linux@...r.kernel.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"dakr@...nel.org" <dakr@...nel.org>, Alexandre Courbot <acourbot@...dia.com>,
	Alistair Popple <apopple@...dia.com>, Miguel Ojeda <ojeda@...nel.org>, Alex
 Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>, Gary Guo
	<gary@...yguo.net>, "bjorn3_gh@...tonmail.com" <bjorn3_gh@...tonmail.com>,
	Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>,
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, David
 Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Maarten
 Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard
	<mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, Timur Tabi
	<ttabi@...dia.com>, "joel@...lfernandes.org" <joel@...lfernandes.org>,
	"nouveau@...ts.freedesktop.org" <nouveau@...ts.freedesktop.org>
Subject: Re: [PATCH v2 08/12] nova-core: sequencer: Add register opcodes



> On Nov 4, 2025, at 9:50 PM, John Hubbard <jhubbard@...dia.com> wrote:
> 
> On 11/2/25 3:59 PM, Joel Fernandes wrote:
>> These opcodes are used for register write, modify, poll and store (save)
>> sequencer operations.
>> 
>> Signed-off-by: Joel Fernandes <joelagnelf@...dia.com>
>> ---
>> drivers/gpu/nova-core/gsp/sequencer.rs | 138 +++++++++++++++++++++++--
>> 1 file changed, 131 insertions(+), 7 deletions(-)
> ...
>> @@ -83,12 +116,103 @@ pub(crate) trait GspSeqCmdRunner {
>>     fn run(&self, sequencer: &GspSequencer<'_>) -> Result;
>> }
>> 
>> -impl GspSeqCmdRunner for GspSeqCmd {
>> -    fn run(&self, _seq: &GspSequencer<'_>) -> Result {
>> +impl GspSeqCmdRunner for fw::GSP_SEQ_BUF_PAYLOAD_REG_WRITE {
>> +    fn run(&self, sequencer: &GspSequencer<'_>) -> Result {
>> +        dev_dbg!(
>> +            sequencer.dev,
>> +            "RegWrite: addr=0x{:x}, val=0x{:x}\n",
> 
> Hi Joel,
> 
> The RegRead, RegWrite, RegPoll prints generate over 400 lines
> per GPU, into the logs. This is too much, especially now that
> it's been working for a while.
> 
> I'm thinking let's delete these entirely. If we somehow get
> into debugging this aspect of the sequencer, we can temporarily
> add whatever printing we need, but I think it's one notch too
> far for the final product, now that you have it working.

Sure John, I am Ok with removing the prints. I will do so for the next spin.

Thanks.




> 
> 
> thanks,
> --
> John Hubbard
>