linux-kernel - Re: [PATCH net-next v3] net: mana: Fix incorrect speed reported by debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d09ceb78-4f86-4114-8596-9b3d102de96b@intel.com>
Date: Wed, 5 Nov 2025 14:15:58 -0800
From: Jacob Keller <jacob.e.keller@...el.com>
To: Erni Sri Satya Vennela <ernis@...ux.microsoft.com>, <kys@...rosoft.com>,
	<haiyangz@...rosoft.com>, <wei.liu@...nel.org>, <decui@...rosoft.com>,
	<andrew+netdev@...n.ch>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <shradhagupta@...ux.microsoft.com>,
	<ssengar@...ux.microsoft.com>, <dipayanroy@...ux.microsoft.com>,
	<shirazsaleem@...rosoft.com>, <kotaranov@...rosoft.com>,
	<longli@...rosoft.com>, <linux-hyperv@...r.kernel.org>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v3] net: mana: Fix incorrect speed reported by
 debugfs



On 11/5/2025 11:04 AM, Erni Sri Satya Vennela wrote:
> Once the netshaper is created for MANA, the current bandwidth
> is reported in debugfs like this:
> 
> $ sudo ./tools/net/ynl/pyynl/cli.py \
>   --spec Documentation/netlink/specs/net_shaper.yaml \
>   --do set \
>   --json '{"ifindex":'3',
>            "handle":{ "scope": "netdev", "id":'1' },
>            "bw-max": 200000000 }'
> None
> 
> $ sudo cat /sys/kernel/debug/mana/1/vport0/current_speed
> 200
> 
> After the shaper  is deleted, it is expected to report
> the maximum speed supported by the SKU. But currently it is
> reporting 0, which is incorrect.
> 
> Fix this inconsistency, by resetting apc->speed to apc->max_speed
> during deletion of the shaper object. This will improve
> readability and debuggability.
> 
> Signed-off-by: Erni Sri Satya Vennela <ernis@...ux.microsoft.com>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

> Changes in v3:
> * Remove Fixes tag.> Changes in v2:
> * Add Fixes tag.
> ---
>  drivers/net/ethernet/microsoft/mana/mana_en.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c
> index 0142fd98392c..9d56bfefd755 100644
> --- a/drivers/net/ethernet/microsoft/mana/mana_en.c
> +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c
> @@ -814,7 +814,7 @@ static int mana_shaper_del(struct net_shaper_binding *binding,
>  		/* Reset mana port context parameters */
>  		apc->handle.id = 0;
>  		apc->handle.scope = NET_SHAPER_SCOPE_UNSPEC;
> -		apc->speed = 0;
> +		apc->speed = apc->max_speed;
>  	}
>  
>  	return err;



Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)