linux-kernel - Re: [PATCH v2 05/12] nova-core: gsp: Add support for checking if GSP reloaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eac72108-6912-45fb-bb1e-43d5e931be9f@nvidia.com>
Date: Wed, 5 Nov 2025 15:29:50 -0800
From: John Hubbard <jhubbard@...dia.com>
To: Lyude Paul <lyude@...hat.com>, Joel Fernandes <joelagnelf@...dia.com>,
 linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, dakr@...nel.org, acourbot@...dia.com
Cc: Alistair Popple <apopple@...dia.com>, Miguel Ojeda <ojeda@...nel.org>,
 Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>,
 Gary Guo <gary@...yguo.net>, bjorn3_gh@...tonmail.com,
 Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>,
 Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 Timur Tabi <ttabi@...dia.com>, joel@...lfernandes.org,
 nouveau@...ts.freedesktop.org
Subject: Re: [PATCH v2 05/12] nova-core: gsp: Add support for checking if GSP
 reloaded

On 11/5/25 3:18 PM, Lyude Paul wrote:
...
>> diff --git a/drivers/gpu/nova-core/falcon/gsp.rs b/drivers/gpu/nova-core/falcon/gsp.rs
>> index f17599cb49fa..e0c0b18ec5bf 100644
>> --- a/drivers/gpu/nova-core/falcon/gsp.rs
>> +++ b/drivers/gpu/nova-core/falcon/gsp.rs
>> @@ -1,5 +1,11 @@
>>  // SPDX-License-Identifier: GPL-2.0
>>  
>> +use kernel::{
>> +    io::poll::read_poll_timeout,
>> +    prelude::*,
>> +    time::Delta, //
> 
> Looks like a wild // got loose!

Not at all. This is the new normal, until rustfmt gets updated.
The idea is to avoid merge conflicts in "use" statements, by
having one item per line. The trailing ", //" is a hack that
forces the desired behavior.

As per Miguel Ojeda's note, here:

https://lore.kernel.org/all/CANiq72kDB1cX1XXX7sc3yQvnaUUYB8q1wVKNxykv8=OV-=rWuQ@mail.gmail.com/


thanks,
-- 
John Hubbard