linux-kernel - Re: [PATCH v2 05/12] nova-core: gsp: Add support for checking if GSP reloaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DE16OCTBYT7G.3FMDZ8CPMGJKM@nvidia.com>
Date: Thu, 06 Nov 2025 09:26:03 +0900
From: "Alexandre Courbot" <acourbot@...dia.com>
To: "Lyude Paul" <lyude@...hat.com>, "Joel Fernandes"
 <joelagnelf@...dia.com>, <linux-kernel@...r.kernel.org>,
 <rust-for-linux@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
 <dakr@...nel.org>, <acourbot@...dia.com>
Cc: "Alistair Popple" <apopple@...dia.com>, "Miguel Ojeda"
 <ojeda@...nel.org>, "Alex Gaynor" <alex.gaynor@...il.com>, "Boqun Feng"
 <boqun.feng@...il.com>, "Gary Guo" <gary@...yguo.net>,
 <bjorn3_gh@...tonmail.com>, "Benno Lossin" <lossin@...nel.org>, "Andreas
 Hindborg" <a.hindborg@...nel.org>, "Alice Ryhl" <aliceryhl@...gle.com>,
 "Trevor Gross" <tmgross@...ch.edu>, "David Airlie" <airlied@...il.com>,
 "Simona Vetter" <simona@...ll.ch>, "Maarten Lankhorst"
 <maarten.lankhorst@...ux.intel.com>, "Maxime Ripard" <mripard@...nel.org>,
 "Thomas Zimmermann" <tzimmermann@...e.de>, "John Hubbard"
 <jhubbard@...dia.com>, "Timur Tabi" <ttabi@...dia.com>,
 <joel@...lfernandes.org>, <nouveau@...ts.freedesktop.org>, "Nouveau"
 <nouveau-bounces@...ts.freedesktop.org>
Subject: Re: [PATCH v2 05/12] nova-core: gsp: Add support for checking if
 GSP reloaded

On Thu Nov 6, 2025 at 8:18 AM JST, Lyude Paul wrote:
> Minor comments:
>
> On Sun, 2025-11-02 at 18:59 -0500, Joel Fernandes wrote:
>> During the sequencer process, we need to check if GSP was successfully
>> reloaded. Add functionality to check for the same.
>> 
>> Signed-off-by: Joel Fernandes <joelagnelf@...dia.com>
>> ---
>>  drivers/gpu/nova-core/falcon/gsp.rs | 18 ++++++++++++++++++
>>  drivers/gpu/nova-core/regs.rs       |  6 ++++++
>>  2 files changed, 24 insertions(+)
>> 
>> diff --git a/drivers/gpu/nova-core/falcon/gsp.rs b/drivers/gpu/nova-core/falcon/gsp.rs
>> index f17599cb49fa..e0c0b18ec5bf 100644
>> --- a/drivers/gpu/nova-core/falcon/gsp.rs
>> +++ b/drivers/gpu/nova-core/falcon/gsp.rs
>> @@ -1,5 +1,11 @@
>>  // SPDX-License-Identifier: GPL-2.0
>>  
>> +use kernel::{
>> +    io::poll::read_poll_timeout,
>> +    prelude::*,
>> +    time::Delta, //
>
> Looks like a wild // got loose!

It's a bit confusing at first but this is to conform with the new rules
for imports. :)

https://docs.kernel.org/rust/coding-guidelines.html#imports

Thanks for the reviews!