linux-kernel - Re: [PATCH] input: elan_i2c: Add newline to sysfs attribute outputs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <186a650b-50a7-4b29-8c00-5e0b1d9d2ecc@oss.qualcomm.com>
Date: Wed, 5 Nov 2025 14:28:32 +0800
From: Zhongqiu Han <zhongqiu.han@....qualcomm.com>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: krzk@...nel.org, linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        zhongqiu.han@....qualcomm.com
Subject: Re: [PATCH] input: elan_i2c: Add newline to sysfs attribute outputs

On 11/5/2025 12:55 PM, Dmitry Torokhov wrote:
> Hi Zhongqiu,
> 
> On Thu, Oct 30, 2025 at 08:34:58PM +0800, Zhongqiu Han wrote:
>> Append newline characters to sysfs_emit() outputs in func min_show() and
>> max_show(). This aligns with common kernel conventions and improves
>> readability for userspace tools that expect newline-terminated values.
> 
> This format for this driver was in use for 11 years, and there might be
> tools that do not expect newlines. I would rather leave it as is.
> 
> Thanks.
> 

Hi Dmitry,

Thanks for your review~

Sure, I agree that we should avoid breaking unknown userspace tools.


-- 
Thx and BRs,
Zhongqiu Han