linux-kernel - Re: [PATCH] input: elan_i2c: Add newline to sysfs attribute outputs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <swn2pwumb7ffpcyer6n5nn6zbdjvxtwxprddymhxzdjzx4lbr5@hkwusbsr5uks>
Date: Tue, 4 Nov 2025 20:55:53 -0800
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Zhongqiu Han <zhongqiu.han@....qualcomm.com>
Cc: krzk@...nel.org, linux-input@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] input: elan_i2c: Add newline to sysfs attribute outputs

Hi Zhongqiu,

On Thu, Oct 30, 2025 at 08:34:58PM +0800, Zhongqiu Han wrote:
> Append newline characters to sysfs_emit() outputs in func min_show() and
> max_show(). This aligns with common kernel conventions and improves
> readability for userspace tools that expect newline-terminated values.

This format for this driver was in use for 11 years, and there might be
tools that do not expect newlines. I would rather leave it as is.

Thanks.

-- 
Dmitry