linux-kernel - Re: [PATCH net-next v04 2/5] hinic3: Add PF management interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aQsJ8a4XXE3HXR7A@horms.kernel.org>
Date: Wed, 5 Nov 2025 08:25:21 +0000
From: Simon Horman <horms@...nel.org>
To: Fan Gong <gongfan1@...wei.com>
Cc: Zhu Yikai <zhuyikai1@...artners.com>, netdev@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, Markus.Elfring@....de,
	pavan.chebbi@...adcom.com, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org, luosifu <luosifu@...wei.com>,
	Xin Guo <guoxin09@...wei.com>,
	Shen Chenyang <shenchenyang1@...ilicon.com>,
	Zhou Shuai <zhoushuai28@...wei.com>, Wu Like <wulike1@...wei.com>,
	Shi Jing <shijing34@...wei.com>,
	Luo Yang <luoyang82@...artners.com>,
	Meny Yossefi <meny.yossefi@...wei.com>,
	Gur Stavi <gur.stavi@...wei.com>
Subject: Re: [PATCH net-next v04 2/5] hinic3: Add PF management interfaces

On Wed, Oct 29, 2025 at 02:16:26PM +0800, Fan Gong wrote:

...

> diff --git a/drivers/net/ethernet/huawei/hinic3/hinic3_netdev_ops.c b/drivers/net/ethernet/huawei/hinic3/hinic3_netdev_ops.c

...

> +static void hinic3_print_link_message(struct net_device *netdev,
> +				      bool link_status_up)
> +{
> +	struct hinic3_nic_dev *nic_dev = netdev_priv(netdev);
> +
> +	if (nic_dev->link_status_up == link_status_up)
> +		return;
> +
> +	nic_dev->link_status_up = link_status_up;
> +
> +	netdev_dbg(netdev, "Link is %s\n", (link_status_up ? "up" : "down"));

Hi Fan Gong, all,

Coccinelle suggests that str_up_down() could be used here,
which does seem like a reasonable suggestion as it seems
there will be a v5 anyway.

> +}

...