linux-kernel - Re: [PATCH v5 1/2] dt-bindings: firmware: svc: Add IOMMU support for Agilex5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251105-giga-ostrich-of-prosperity-410d1c@kuoka>
Date: Wed, 5 Nov 2025 09:23:43 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Khairul Anuar Romli <khairul.anuar.romli@...era.com>
Cc: Dinh Nguyen <dinguyen@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Mahesh Rao <mahesh.rao@...era.com>, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, 
	Adrian Ng Ho Yin <adrianhoyin.ng@...era.com>, Niravkumar L Rabara <niravkumarlaxmidas.rabara@...era.com>
Subject: Re: [PATCH v5 1/2] dt-bindings: firmware: svc: Add IOMMU support for
 Agilex5

On Wed, Nov 05, 2025 at 10:28:01AM +0800, Khairul Anuar Romli wrote:
> In Agilex5, the TBU (Translation Buffer Unit) can now operate in non-secure
> mode, enabling Linux to utilize it through the IOMMU framework. This allows
> improved memory management capabilities in non-secure environments. With
> Agilex5 lifting this restriction, we are now extending the device tree
> bindings to support IOMMU for the Agilex5 SVC.
> 
> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@...era.com>
> ---
> Changes in v5:
> 	- Use contains enum instead of const
> Changes in v4:
> 	- Fix syntax / style error.
> 	- Refactor code not to use AllOf but instead use if directly.

Why? I would expect there allOf, so you won't re-indent when next
if:then: clause comes.

Anyway, slow down with your patches - one posting per 24h. That's like
three versions within that timeframe...


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof